Chromium Code Reviews
DescriptionRevert of Add an early abort for the CSSParserFastPaths transform path. (patchset #5 id:80001 of https://codereview.chromium.org/1996343003/ )
Reason for revert:
This might be causing a timeout in several perf tests.
Original issue's description:
> Add an early abort for the CSSParserFastPaths transform path.
>
> For transforms that miss the fast path like
> "transform(1px, 1px) rotate(1deg)" we end up spending a lot of time
> building the transform list and doing string to double conversions for
> the function calls we do understand that were listed before the ones we
> didn't understand. This work ends up wasted and we have to redo it all
> inside the real CSSParser later.
>
> This patch introduces a scan over the string that tries to reject all
> transform things we don't understand in advance.
>
> This is not the best, since ideally we'd just remove the fast path and
> make the real parser just as fast, but in the meantime this at least
> avoids doing lots of wasted work.
>
> This patch makes the script in Animometer > Leaves 8% faster.
>
> The change is covered by the tests introduced in:
> https://codereview.chromium.org/2007823002
>
> BUG=606211
>
> Committed: https://crrev.com/ad21c7423bc912e4c5287204d7c1eb57b994099a
> Cr-Commit-Position: refs/heads/master@{#395797}
TBR=meade@chromium.org,timloh@chromium.org,dstockwell@chromium.org,esprehn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=606211
Committed: https://crrev.com/1252d54ec614bb49f87a25c60fd5ce74eaa87be4
Cr-Commit-Position: refs/heads/master@{#395957}
Patch Set 1 #
Messages
Total messages: 7 (1 generated)
|
|||||||||||||||||||