Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2009723003: Revert of Add an early abort for the CSSParserFastPaths transform path. (Closed)

Created:
4 years, 7 months ago by RobertoCN
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add an early abort for the CSSParserFastPaths transform path. (patchset #5 id:80001 of https://codereview.chromium.org/1996343003/ ) Reason for revert: This might be causing a timeout in several perf tests. Original issue's description: > Add an early abort for the CSSParserFastPaths transform path. > > For transforms that miss the fast path like > "transform(1px, 1px) rotate(1deg)" we end up spending a lot of time > building the transform list and doing string to double conversions for > the function calls we do understand that were listed before the ones we > didn't understand. This work ends up wasted and we have to redo it all > inside the real CSSParser later. > > This patch introduces a scan over the string that tries to reject all > transform things we don't understand in advance. > > This is not the best, since ideally we'd just remove the fast path and > make the real parser just as fast, but in the meantime this at least > avoids doing lots of wasted work. > > This patch makes the script in Animometer > Leaves 8% faster. > > The change is covered by the tests introduced in: > https://codereview.chromium.org/2007823002 > > BUG=606211 > > Committed: https://crrev.com/ad21c7423bc912e4c5287204d7c1eb57b994099a > Cr-Commit-Position: refs/heads/master@{#395797} TBR=meade@chromium.org,timloh@chromium.org,dstockwell@chromium.org,esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606211 Committed: https://crrev.com/1252d54ec614bb49f87a25c60fd5ce74eaa87be4 Cr-Commit-Position: refs/heads/master@{#395957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -56 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 3 chunks +13 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
RobertoCN
Created Revert of Add an early abort for the CSSParserFastPaths transform path.
4 years, 7 months ago (2016-05-25 19:18:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009723003/1
4 years, 7 months ago (2016-05-25 19:19:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 19:19:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1252d54ec614bb49f87a25c60fd5ce74eaa87be4 Cr-Commit-Position: refs/heads/master@{#395957}
4 years, 7 months ago (2016-05-25 19:21:03 UTC) #5
Timothy Loh
On 2016/05/25 19:21:03, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 7 months ago (2016-05-26 01:34:51 UTC) #6
esprehn
4 years, 7 months ago (2016-05-26 20:18:45 UTC) #7
Message was sent while issue was closed.
On 2016/05/26 at 01:34:51, timloh wrote:
> On 2016/05/25 19:21:03, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/1252d54ec614bb49f87a25c60fd5ce74eaa87be4
> > Cr-Commit-Position: refs/heads/master@{#395957}
> 
> It would be helpful to link to the failing perf tests here.

It was this:
https://bugs.chromium.org/p/chromium/issues/detail?id=614765#c3

@robertocn In the future please add a bug link to the revert. Thanks! :)

Powered by Google App Engine
This is Rietveld 408576698