Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2007823002: Fix whitespace handling in parseSimpleTransformList (Closed)

Created:
4 years, 7 months ago by esprehn
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix whitespace handling in parseSimpleTransformList The loop would break if there was any trailing whitespace after the args of the transform operation function, but this meant that if you put a space between the functions like 'translateX(1px) translateY(1px)' you'd fall out of the fast path when hitting the space between the two functions. Any trailing space would similarly fall out of the fast path and result in wasting all of the work building the transform list only to discard it. This patch instead skips whitespace between the functions and also adds a bunch of tests for the fast paths. BUG=606211 Committed: https://crrev.com/5f88403bf3e53a955cee48e172269d0ed94f2595 Cr-Commit-Position: refs/heads/master@{#395610}

Patch Set 1 #

Patch Set 2 : only transform tests for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007823002/1
4 years, 7 months ago (2016-05-24 05:09:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007823002/20001
4 years, 7 months ago (2016-05-24 05:11:35 UTC) #5
esprehn
4 years, 7 months ago (2016-05-24 06:00:58 UTC) #7
Timothy Loh
On 2016/05/24 06:00:58, esprehn wrote: lgtm
4 years, 7 months ago (2016-05-24 06:13:46 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 09:20:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007823002/20001
4 years, 7 months ago (2016-05-24 16:02:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007823002/20001
4 years, 7 months ago (2016-05-24 16:04:00 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 16:10:14 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 16:12:17 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f88403bf3e53a955cee48e172269d0ed94f2595
Cr-Commit-Position: refs/heads/master@{#395610}

Powered by Google App Engine
This is Rietveld 408576698