content/browser/service_worker/service_worker_storage_unittest.cc - Issue 2009453002: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage_unittest.cc

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: selfreview Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_request_handler.cc ('K') | « content/browser/service_worker/service_worker_request_handler_unittest.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | content/common/service_worker/service_worker_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage_unittest.cc

diff --git a/content/browser/service_worker/service_worker_storage_unittest.cc b/content/browser/service_worker/service_worker_storage_unittest.cc

index ac3281ea0a913b64057f3b3ae6750f0058125490..1740a1c9cdd29600a94e3fa43f21b7fdb495d7eb 100644

--- a/content/browser/service_worker/service_worker_storage_unittest.cc

+++ b/content/browser/service_worker/service_worker_storage_unittest.cc

@@ -1276,7 +1276,7 @@ TEST_F(ServiceWorkerResourceStorageTest, DeleteRegistration_ActiveVersion) {

std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

33 /* dummy render process id */, MSG_ROUTING_NONE,

1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- context()->AsWeakPtr(), NULL));

+ true /* is_parent_frame_secure */, context()->AsWeakPtr(), NULL));

registration_->active_version()->AddControllee(host.get());

bool was_called = false;

@@ -1327,7 +1327,7 @@ TEST_F(ServiceWorkerResourceStorageDiskTest, CleanupOnRestart) {

std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

33 /* dummy render process id */, MSG_ROUTING_NONE,

1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- context()->AsWeakPtr(), NULL));

+ true /* is_parent_frame_secure */, context()->AsWeakPtr(), NULL));

registration_->active_version()->AddControllee(host.get());

bool was_called = false;

@@ -1486,7 +1486,7 @@ TEST_F(ServiceWorkerResourceStorageTest, UpdateRegistration) {

std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

33 /* dummy render process id */, MSG_ROUTING_NONE,

1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- context()->AsWeakPtr(), NULL));

+ true /* is_parent_frame_secure */, context()->AsWeakPtr(), NULL));

registration_->active_version()->AddControllee(host.get());

bool was_called = false;