content/common/service_worker/service_worker_messages.h - Issue 2009453002: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: selfreview Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_request_handler.cc ('K') | « content/child/service_worker/service_worker_network_provider.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 05f22dfb46b64d799e5f77e0d9c32798ce9e4b7b..9413fa5f8a3391cc895681c79502dcd9461babb5 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -203,10 +203,11 @@ IPC_MESSAGE_CONTROL5(

// MSG_ROUTING_NONE. |provider_type| identifies whether this provider is for

// Service Worker controllees (documents and Shared Workers) or for controllers

// (Service Workers).

alexmos 2016/06/02 23:54:47 Update this comment to describe |is_parent_frame_s

falken 2016/06/03 08:22:05 Done.

-IPC_MESSAGE_CONTROL3(ServiceWorkerHostMsg_ProviderCreated,

+IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_ProviderCreated,

int /* provider_id */,

int /* route_id */,

- content::ServiceWorkerProviderType /* provider_type */)

+ content::ServiceWorkerProviderType /* provider_type */,

+ bool /* is_parent_frame_secure */)

// Informs the browser of a ServiceWorkerProvider being destroyed.

IPC_MESSAGE_CONTROL1(ServiceWorkerHostMsg_ProviderDestroyed,