Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2009443002: Revert of Consolidate OutputSurface constructors into GL vs Vulkan. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
CC:
chromium-reviews, sievers+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, khushalsagar+watch-blimp_chromium.org, rjkroege, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, Ian Vollick, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Consolidate OutputSurface constructors into GL vs Vulkan. (patchset #7 id:120001 of https://codereview.chromium.org/2002303002/ ) Reason for revert: Caused 14,366 crashes on Windows layout test bots. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/42641 Original issue's description: > Consolidate OutputSurface constructors into GL vs Vulkan. > > Get rid of the many many constructors on OutputSurface, drop it down > to constructors for GL based compositing vs Vulkan based. > > R=boliu@chromium.org, piman, sievers > TBR=sky, torne > BUG=487471 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/6daedd173180936d9c56976a276a91ff761da68a > Cr-Commit-Position: refs/heads/master@{#395478} TBR=boliu@chromium.org,piman@chromium.org,sievers@chromium.org,nyquist@chromium.org,sky@chromium.org,torne@chromium.org,rjkroege@chromium.org,fsamuel@chromium.org,danakj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487471 Committed: https://crrev.com/0d89533d86de7a55f4caa39d1cfc4772142337a6 Cr-Commit-Position: refs/heads/master@{#395532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -349 lines) Patch
M android_webview/browser/parent_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_output_surface.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M cc/output/output_surface.h View 4 chunks +16 lines, -13 lines 0 comments Download
M cc/output/output_surface.cc View 1 chunk +37 lines, -5 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 3 chunks +21 lines, -10 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M cc/test/failure_output_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_output_surface.h View 4 chunks +7 lines, -5 lines 0 comments Download
M cc/test/fake_output_surface.cc View 1 chunk +32 lines, -12 lines 0 comments Download
M cc/test/pixel_test_output_surface.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M components/display_compositor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/display_compositor/buffer_queue.h View 3 chunks +6 lines, -6 lines 0 comments Download
M components/display_compositor/buffer_queue.cc View 9 chunks +36 lines, -26 lines 0 comments Download
M components/display_compositor/buffer_queue_unittest.cc View 6 chunks +27 lines, -39 lines 0 comments Download
M components/mus/public/cpp/lib/output_surface.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/surfaces/direct_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/surfaces/direct_output_surface_ozone.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/direct_output_surface_ozone.cc View 6 chunks +20 lines, -20 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 5 chunks +23 lines, -13 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 2 chunks +84 lines, -48 lines 0 comments Download
A content/renderer/gpu/delegated_compositor_output_surface.h View 1 chunk +31 lines, -0 lines 0 comments Download
A content/renderer/gpu/delegated_compositor_output_surface.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M content/renderer/gpu/mailbox_output_surface.h View 4 chunks +12 lines, -15 lines 0 comments Download
M content/renderer/gpu/mailbox_output_surface.cc View 6 chunks +34 lines, -65 lines 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +15 lines, -13 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
tkent
Created Revert of Consolidate OutputSurface constructors into GL vs Vulkan.
4 years, 7 months ago (2016-05-24 05:33:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009443002/1
4 years, 7 months ago (2016-05-24 05:34:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 05:35:20 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 05:37:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d89533d86de7a55f4caa39d1cfc4772142337a6
Cr-Commit-Position: refs/heads/master@{#395532}

Powered by Google App Engine
This is Rietveld 408576698