Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2009373002: Remove unused variables. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 7 months ago
Reviewers:
Devlin, lazyboy, hcarmona
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused variables. These changes were already approved and landed as part of https://codereview.chromium.org/1981053002/ , which got reverted. Relanding them separately so they don't risk being reverted again. BUG=447156 TEST=none R=hcarmona@chromium.org, rdevlin.cronin@chromium.org TBR=hcarmona, lazyboy, rdevlin.cronin Committed: https://chromium.googlesource.com/chromium/src/+/aa2c17efbde5ab8fed19b752904af8c41334480e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/extensions/api/autofill_private/autofill_private_event_router.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/extension_service_worker_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_service_worker_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Peter Kasting
4 years, 7 months ago (2016-05-25 20:32:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009373002/1
4 years, 7 months ago (2016-05-25 20:33:19 UTC) #5
Devlin
lgtm
4 years, 7 months ago (2016-05-25 20:34:32 UTC) #6
hcarmona
lgtm
4 years, 7 months ago (2016-05-25 20:39:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/176098) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-25 20:49:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009373002/1
4 years, 7 months ago (2016-05-25 20:50:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/235546)
4 years, 7 months ago (2016-05-25 22:47:23 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa2c17efbde5ab8fed19b752904af8c41334480e Cr-Commit-Position: refs/heads/master@{#396026}
4 years, 7 months ago (2016-05-25 23:01:10 UTC) #15
Peter Kasting
4 years, 7 months ago (2016-05-25 23:02:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa2c17efbde5ab8fed19b752904af8c41334480e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698