third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame.html - Issue 2009353003: Add a hack to set shouldPaint to true for force-composited iframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame.html

Issue 2009353003: Add a hack to set shouldPaint to true for force-composited iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame-expected.html » ('j') | third_party/WebKit/Source/core/layout/FloatingObjects.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 iframe {

	4 float: left;

	5 height: 100%;

	6 width: 100%;

	7 }

	8 </style>

	9 <iframe id="target" name="content" srcdoc="<div style='width: 300px; height:400 px; background: blue'></div>" style="height: 119px;"></iframe>

	10 <script>

	11 if (window.internals)

	12 window.internals.settings.setPreferCompositingToLCDTextEnabled(true);

	13 onload = function() {
	Xianzhu 2016/05/26 18:29:54 I think we should use runAfterLayoutAndPaint() bec I think we should use runAfterLayoutAndPaint() because onload may not ensure a compositing update. chrishtr 2016/05/26 18:49:29 Done. Show quoted text On 2016/05/26 at 18:29:54, Xianzhu wrote: > I think we should use runAfterLayoutAndPaint() because onload may not ensure a compositing update. Done.
	14 target.style.height = "600px";

	15 }

	16 </script>

OLD	NEW