third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2009283002: Fix touch accessibility events in WebViews and iframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2009283002: Fix touch accessibility events in WebViews and iframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable cross-site test temporarily Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/web/WebInputEventConversion.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index efc395d5be6f97e2746000332fbf7d235d760db8..04665908c780aa40d172987127d380aa1fcc186f 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -1252,8 +1252,15 @@ String AXObjectCacheImpl::computedNameForNode(Node* node)

void AXObjectCacheImpl::onTouchAccessibilityHover(const IntPoint& location)

{

AXObject* hit = root()->accessibilityHitTest(location);

- if (hit)

+ if (hit) {

+ // Ignore events on a frame or plug-in, because the touch events

+ // will be re-targeted there and we don't want to fire duplicate

+ // accessibility events.

+ if (hit->getLayoutObject() && hit->getLayoutObject()->isLayoutPart())

+ return;

postPlatformNotification(hit, AXHover);

+ }

}

void AXObjectCacheImpl::setCanvasObjectBounds(Element* element, const LayoutRect& rect)