Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2009283002: Fix touch accessibility events in WebViews and iframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable cross-site test temporarily Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014, Google Inc. All rights reserved. 2 * Copyright (C) 2014, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1234 matching lines...) Expand 10 before | Expand all | Expand 10 after
1245 AXObject* obj = getOrCreate(node); 1245 AXObject* obj = getOrCreate(node);
1246 if (!obj) 1246 if (!obj)
1247 return ""; 1247 return "";
1248 1248
1249 return obj->computedName(); 1249 return obj->computedName();
1250 } 1250 }
1251 1251
1252 void AXObjectCacheImpl::onTouchAccessibilityHover(const IntPoint& location) 1252 void AXObjectCacheImpl::onTouchAccessibilityHover(const IntPoint& location)
1253 { 1253 {
1254 AXObject* hit = root()->accessibilityHitTest(location); 1254 AXObject* hit = root()->accessibilityHitTest(location);
1255 if (hit) 1255 if (hit) {
1256 // Ignore events on a frame or plug-in, because the touch events
1257 // will be re-targeted there and we don't want to fire duplicate
1258 // accessibility events.
1259 if (hit->getLayoutObject() && hit->getLayoutObject()->isLayoutPart())
1260 return;
1261
1256 postPlatformNotification(hit, AXHover); 1262 postPlatformNotification(hit, AXHover);
1263 }
1257 } 1264 }
1258 1265
1259 void AXObjectCacheImpl::setCanvasObjectBounds(Element* element, const LayoutRect & rect) 1266 void AXObjectCacheImpl::setCanvasObjectBounds(Element* element, const LayoutRect & rect)
1260 { 1267 {
1261 AXObject* obj = getOrCreate(element); 1268 AXObject* obj = getOrCreate(element);
1262 if (!obj) 1269 if (!obj)
1263 return; 1270 return;
1264 1271
1265 obj->setElementRect(rect); 1272 obj->setElementRect(rect);
1266 } 1273 }
1267 1274
1268 DEFINE_TRACE(AXObjectCacheImpl) 1275 DEFINE_TRACE(AXObjectCacheImpl)
1269 { 1276 {
1270 visitor->trace(m_document); 1277 visitor->trace(m_document);
1271 visitor->trace(m_nodeObjectMapping); 1278 visitor->trace(m_nodeObjectMapping);
1272 1279
1273 visitor->trace(m_objects); 1280 visitor->trace(m_objects);
1274 visitor->trace(m_notificationsToPost); 1281 visitor->trace(m_notificationsToPost);
1275 1282
1276 AXObjectCache::trace(visitor); 1283 AXObjectCache::trace(visitor);
1277 } 1284 }
1278 1285
1279 } // namespace blink 1286 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698