Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Unified Diff: xfa/fgas/font/fgas_stdfontmgr.h

Issue 2009253003: Clean up fx_ge.h and IWYU. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: win Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fgas/font/fgas_stdfontmgr.h
diff --git a/xfa/fgas/font/fgas_stdfontmgr.h b/xfa/fgas/font/fgas_stdfontmgr.h
index bbfa875e5e7175615082b06c2c5ace721af14712..7161636fdd40fe7e4b1e878b2b8d40e06aaa594e 100644
--- a/xfa/fgas/font/fgas_stdfontmgr.h
+++ b/xfa/fgas/font/fgas_stdfontmgr.h
@@ -9,7 +9,6 @@
#include "core/fxcrt/include/fx_ext.h"
#include "core/fxge/include/fx_freetype.h"
-#include "core/fxge/include/fx_ge.h"
#include "third_party/freetype/include/freetype/fttypes.h"
#include "xfa/fgas/font/fgas_font.h"
@@ -21,7 +20,7 @@ FX_FONTDESCRIPTOR const* FX_DefFontMatcher(FX_LPFONTMATCHPARAMS pParams,
class CFX_StdFontMgrImp : public IFX_FontMgr {
public:
- CFX_StdFontMgrImp(FX_LPEnumAllFonts pEnumerator);
+ explicit CFX_StdFontMgrImp(FX_LPEnumAllFonts pEnumerator);
~CFX_StdFontMgrImp();
virtual void Release() { delete this; }
virtual IFX_Font* GetDefFontByCodePage(uint16_t wCodePage,
dsinclair 2016/05/26 02:55:17 any overrides?
Lei Zhang 2016/05/26 04:23:16 Done.
@@ -144,7 +143,7 @@ class CFX_FontSourceEnum_File {
class CFX_FontMgrImp : public IFX_FontMgr {
public:
- CFX_FontMgrImp(CFX_FontSourceEnum_File* pFontEnum);
+ explicit CFX_FontMgrImp(CFX_FontSourceEnum_File* pFontEnum);
virtual void Release();
virtual IFX_Font* GetDefFontByCodePage(uint16_t wCodePage,
dsinclair 2016/05/26 02:55:17 overrides?
Lei Zhang 2016/05/26 04:23:16 Done.

Powered by Google App Engine
This is Rietveld 408576698