Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/include/fsdk_define.h

Issue 2009253003: Clean up fx_ge.h and IWYU. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: win Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/fsdk_rendercontext.cpp ('k') | xfa/fde/fde_gedevice.h » ('j') | xfa/fgas/font/fgas_stdfontmgr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/fsdk_define.h
diff --git a/fpdfsdk/include/fsdk_define.h b/fpdfsdk/include/fsdk_define.h
index 536e35886f549e611083cc720a900b191595a01b..458e8b01e914b7b895a3f9fdf83993d3f5c92663 100644
--- a/fpdfsdk/include/fsdk_define.h
+++ b/fpdfsdk/include/fsdk_define.h
@@ -9,8 +9,6 @@
#include "core/fpdfapi/fpdf_parser/include/cpdf_parser.h"
#include "core/fpdfdoc/include/fpdf_doc.h"
-#include "core/fxge/include/fx_ge.h"
-#include "core/fxge/include/fx_ge_win32.h"
#include "public/fpdfview.h"
#ifdef PDF_ENABLE_XFA
@@ -63,7 +61,7 @@ class CPDF_CustomAccess final : public IFX_FileRead {
#ifdef PDF_ENABLE_XFA
class CFPDF_FileStream : public IFX_FileStream {
public:
- CFPDF_FileStream(FPDF_FILEHANDLER* pFS);
+ explicit CFPDF_FileStream(FPDF_FILEHANDLER* pFS);
virtual ~CFPDF_FileStream() {}
virtual IFX_FileStream* Retain();
dsinclair 2016/05/26 02:55:17 Should any of these virtuals be overrides?
Lei Zhang 2016/05/26 04:23:16 Done.
« no previous file with comments | « fpdfsdk/fsdk_rendercontext.cpp ('k') | xfa/fde/fde_gedevice.h » ('j') | xfa/fgas/font/fgas_stdfontmgr.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698