Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2009233002: [Binding] [Refactoring] Remove ScriptValueCompositeCreator (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScriptValueCompositeCreator, which was used as an interface for SerializedScriptValueReader. We can replace it with ScriptValueDeserializer. BUG=148757 Committed: https://crrev.com/a0543c3453a4c387f762070412e700b4b59fc584 Cr-Commit-Position: refs/heads/master@{#396144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -94 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 5 chunks +24 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 21 chunks +37 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
peria
PTL
4 years, 7 months ago (2016-05-26 02:34:35 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-26 02:40:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009233002/1
4 years, 7 months ago (2016-05-26 03:38:41 UTC) #7
Yuki
lgtm
4 years, 7 months ago (2016-05-26 06:07:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 08:08:53 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 08:10:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0543c3453a4c387f762070412e700b4b59fc584
Cr-Commit-Position: refs/heads/master@{#396144}

Powered by Google App Engine
This is Rietveld 408576698