Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2009173002: Fix depot_tools\git.bat when depot_tools in not in PATH (Closed)

Created:
4 years, 7 months ago by anatoly techtonik
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix depot_tools\git.bat when depot_tools in not in PATH R=iannucci@chromium.org, dpranke@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bootstrap/win/git.template.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (3 generated)
anatoly techtonik
4 years, 7 months ago (2016-05-25 07:36:52 UTC) #1
anatoly techtonik
4 years, 7 months ago (2016-05-25 07:37:36 UTC) #2
Dirk Pranke
Why would depot_tools need to be in the path for this? What git command will ...
4 years, 7 months ago (2016-05-25 15:46:17 UTC) #3
anatoly techtonik
On 2016/05/25 15:46:17, Dirk Pranke (slow) wrote: > Why would depot_tools need to be in ...
4 years, 7 months ago (2016-05-25 16:11:21 UTC) #4
Dirk Pranke
On 2016/05/25 16:11:21, anatoly techtonik wrote: > On 2016/05/25 15:46:17, Dirk Pranke (slow) wrote: > ...
4 years, 7 months ago (2016-05-25 16:12:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009173002/1
4 years, 7 months ago (2016-05-25 18:09:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/490)
4 years, 7 months ago (2016-05-25 18:13:06 UTC) #9
anatoly techtonik
I guess it is linefeed problem.
4 years, 7 months ago (2016-05-25 18:52:17 UTC) #10
iannucci
On 2016/05/25 18:52:17, anatoly techtonik wrote: > I guess it is linefeed problem. Yes this ...
4 years, 7 months ago (2016-05-25 20:27:05 UTC) #11
iannucci
I'm not sure how we can commit this without someone taking over this CL :/ ...
4 years, 7 months ago (2016-05-25 20:41:36 UTC) #13
iannucci
On 2016/05/25 20:41:36, iannucci wrote: > I'm not sure how we can commit this without ...
4 years, 7 months ago (2016-05-25 20:46:00 UTC) #14
anatoly techtonik
On 2016/05/25 20:46:00, iannucci wrote: > On 2016/05/25 20:41:36, iannucci wrote: > > I'm not ...
4 years, 7 months ago (2016-05-25 20:48:02 UTC) #15
iannucci
closing in favor of https://codereview.chromium.org/2015673002/
4 years, 7 months ago (2016-05-25 20:48:57 UTC) #16
iannucci
I think that this will get better when we switch to gerrit, where there's no ...
4 years, 7 months ago (2016-05-25 20:49:33 UTC) #17
anatoly techtonik
4 years, 7 months ago (2016-05-26 11:13:58 UTC) #18
Message was sent while issue was closed.
On 2016/05/25 20:49:33, iannucci wrote:
> I think that this will get better when we switch to gerrit, where there's no
> more text patch files.

And how does Gerrit handles that? Does it rely on some internal git changeset
object?

Powered by Google App Engine
This is Rietveld 408576698