Issue 200893004: Remove the ability to lock to multiple orientations.

Issue 200893004: Remove the ability to lock to multiple orientations. (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 9 months ago

Reviewers:
Inactive, abarth-chromium

CC:
blink-reviews, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove the ability to lock to multiple orientations. This is following the latest changes from the specification. BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169381

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -45 lines)			Patch
D	LayoutTests/screen_orientation/lockOrientation-array-argument.html	View		1 chunk	+0 lines, -14 lines	0 comments	Download
D	LayoutTests/screen_orientation/lockOrientation-array-argument-expected.txt	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	LayoutTests/screen_orientation/lockOrientation-bad-argument.html	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.cpp	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Inactive

Looks good with one comment. https://codereview.chromium.org/200893004/diff/1/Source/modules/screen_orientation/ScreenOrientation.cpp File Source/modules/screen_orientation/ScreenOrientation.cpp (left): https://codereview.chromium.org/200893004/diff/1/Source/modules/screen_orientation/ScreenOrientation.cpp#oldcode133 Source/modules/screen_orientation/ScreenOrientation.cpp:133: bool ScreenOrientation::lockOrientation(Screen& screen, const ...

6 years, 9 months ago (2014-03-15 00:29:51 UTC) #2

Inactive

https://codereview.chromium.org/200893004/diff/1/Source/modules/screen_orientation/ScreenOrientation.cpp File Source/modules/screen_orientation/ScreenOrientation.cpp (right): https://codereview.chromium.org/200893004/diff/1/Source/modules/screen_orientation/ScreenOrientation.cpp#newcode135 Source/modules/screen_orientation/ScreenOrientation.cpp:135: blink::WebScreenOrientations orientations = stringToOrientations(orientationString); Does this mean we can ...

6 years, 9 months ago (2014-03-15 00:31:23 UTC) #3

mlamouri (slow - plz ping)

https://codereview.chromium.org/200893004/diff/1/Source/modules/screen_orientation/ScreenOrientation.cpp File Source/modules/screen_orientation/ScreenOrientation.cpp (left): https://codereview.chromium.org/200893004/diff/1/Source/modules/screen_orientation/ScreenOrientation.cpp#oldcode133 Source/modules/screen_orientation/ScreenOrientation.cpp:133: bool ScreenOrientation::lockOrientation(Screen& screen, const Vector<String>& orientationsVector) On 2014/03/15 00:29:52, ...

6 years, 9 months ago (2014-03-15 00:54:46 UTC) #4

Inactive

Lgtm but you will need abarth@ to stamp this as I am not an OWNER ...

6 years, 9 months ago (2014-03-15 02:19:38 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/200893004/20001

6 years, 9 months ago (2014-03-17 18:25:30 UTC) #7

Message was sent while issue was closed.

Change committed as 169381

Expand Messages | Collapse Messages