LayoutTests/screen_orientation/lockOrientation-bad-argument.html - Issue 200893004: Remove the ability to lock to multiple orientations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/lockOrientation-bad-argument.html

Issue 200893004: Remove the ability to lock to multiple orientations. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-array-argument-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/lockOrientation-bad-argument.html

diff --git a/LayoutTests/screen_orientation/lockOrientation-bad-argument.html b/LayoutTests/screen_orientation/lockOrientation-bad-argument.html

index 236f254e6862448f3d9500c2aa8e6df147146baf..8a4fc88ab3c0866a06cb432683107135c31af89c 100644

--- a/LayoutTests/screen_orientation/lockOrientation-bad-argument.html

+++ b/LayoutTests/screen_orientation/lockOrientation-bad-argument.html

@@ -9,7 +9,7 @@ window.jsTestIsAsync = true;

function onOrientationChangeEvent(ev) {

testFailed("Unexpected 'orientationchange' event");

}

function completeTest() {

shouldBeEqualToString("screen.orientation", "portrait-primary");

screen.unlockOrientation();

@@ -29,6 +29,8 @@ shouldBeFalse("screen.lockOrientation(123)");

shouldBeEqualToString("screen.orientation", "portrait-primary");

shouldBeFalse("screen.lockOrientation(window)");

shouldBeEqualToString("screen.orientation", "portrait-primary");

+shouldBeFalse("screen.lockOrientation(['portrait-primary', 'landscape-primary'])");

+shouldBeEqualToString("screen.orientation", "portrait-primary");

shouldThrow("screen.lockOrientation()", '"TypeError: Failed to execute \'lockOrientation\' on \'Screen\': 1 argument required, but only 0 present."');

// Finish asynchronously to give events a chance to fire.