Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2008833002: allow usage of transparent visuals when using xvfb (Closed)

Created:
4 years, 7 months ago by Julien Isorce Samsung
Modified:
4 years, 6 months ago
Reviewers:
danakj, Dirk Pranke, sky, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

allow usage of transparent visuals when using xvfb For the switch kEnableTransparentVisuals to be effective it requires a compositing manager to run. Indeed ui::ChooseVisualForWindow checks for the presence of the Atom _NET_WM_CM_S0 before looking for a 32 bit depth compatible visual. BUG=589509 R=dpranke@chromium.org, piman@chromium.org, sky@chromium.org, danakj@chromium.org Committed: https://crrev.com/b767ddc67b686570d12deea5576ebdbf6fa8b786 Cr-Commit-Position: refs/heads/master@{#397073}

Patch Set 1 #

Patch Set 2 : Add xcompmgr to install-build-deps.sh #

Patch Set 3 : split CL #

Patch Set 4 : Rebase #

Patch Set 5 : Fixes 'ValueError: too many values to unpack' #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M testing/scripts/run_telemetry_as_googletest.py View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M testing/scripts/run_telemetry_benchmark_as_googletest.py View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M testing/xvfb.py View 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 65 (25 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/1
4 years, 7 months ago (2016-05-24 09:00:22 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/234350)
4 years, 7 months ago (2016-05-24 10:19:24 UTC) #4
Julien Isorce Samsung
On 2016/05/24 10:19:24, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 7 months ago (2016-05-24 10:56:53 UTC) #7
Julien Isorce Samsung
On 2016/05/24 10:56:53, Julien Isorce wrote: > On 2016/05/24 10:19:24, commit-bot: I haz the power ...
4 years, 7 months ago (2016-05-24 10:58:02 UTC) #8
Dirk Pranke
I have no understanding of whether we want this to work or not, so I'm ...
4 years, 7 months ago (2016-05-24 19:04:33 UTC) #11
piman
lgtm
4 years, 7 months ago (2016-05-24 19:13:16 UTC) #12
piman
On Tue, May 24, 2016 at 12:04 PM, <dpranke@chromium.org> wrote: > I have no understanding ...
4 years, 7 months ago (2016-05-24 19:15:27 UTC) #13
Dirk Pranke
ok, lgtm. It would be interesting to know if there was much of a increase ...
4 years, 7 months ago (2016-05-24 19:42:29 UTC) #14
sky
On 2016/05/24 19:42:29, Dirk Pranke wrote: > ok, lgtm. It would be interesting to know ...
4 years, 7 months ago (2016-05-24 20:47:48 UTC) #15
Dirk Pranke
On 2016/05/24 20:47:48, sky wrote: > On 2016/05/24 19:42:29, Dirk Pranke wrote: > > ok, ...
4 years, 7 months ago (2016-05-24 21:08:52 UTC) #16
sky
Can't an experimental bot be set up for this? Seems bad that the only want ...
4 years, 7 months ago (2016-05-24 21:33:33 UTC) #17
Dirk Pranke
It's not like it's hard to revert if it causes problems, and setting up experimental ...
4 years, 7 months ago (2016-05-24 21:47:16 UTC) #18
Julien Isorce Samsung
On 2016/05/24 19:42:29, Dirk Pranke wrote: > You'll also need to file a ticket w/ ...
4 years, 7 months ago (2016-05-24 22:16:21 UTC) #19
danakj
On Tue, May 24, 2016 at 3:16 PM, <j.isorce@samsung.com> wrote: > On 2016/05/24 19:42:29, Dirk ...
4 years, 7 months ago (2016-05-24 22:20:06 UTC) #20
Julien Isorce Samsung
On 2016/05/24 22:20:06, danakj wrote: > On Tue, May 24, 2016 at 3:16 PM, <mailto:j.isorce@samsung.com> ...
4 years, 7 months ago (2016-05-24 22:56:51 UTC) #21
danakj
On Tue, May 24, 2016 at 3:56 PM, <j.isorce@samsung.com> wrote: > On 2016/05/24 22:20:06, danakj ...
4 years, 7 months ago (2016-05-24 22:58:41 UTC) #22
Julien Isorce Samsung
On 2016/05/24 22:58:41, danakj wrote: > On Tue, May 24, 2016 at 3:56 PM, <mailto:j.isorce@samsung.com> ...
4 years, 7 months ago (2016-05-25 14:11:09 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/60001
4 years, 7 months ago (2016-05-26 08:20:53 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/236011)
4 years, 7 months ago (2016-05-26 09:26:38 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/60001
4 years, 7 months ago (2016-05-27 03:15:58 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/236641)
4 years, 6 months ago (2016-05-27 04:19:13 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/80001
4 years, 6 months ago (2016-05-27 04:41:24 UTC) #33
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 06:24:18 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/80001
4 years, 6 months ago (2016-05-27 08:01:02 UTC) #37
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 08:04:18 UTC) #39
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/100001
4 years, 6 months ago (2016-05-27 09:31:23 UTC) #41
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 11:04:07 UTC) #43
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/120001
4 years, 6 months ago (2016-05-27 15:56:07 UTC) #45
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 18:08:12 UTC) #47
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/120001
4 years, 6 months ago (2016-05-27 19:33:53 UTC) #49
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 19:37:48 UTC) #51
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/130001
4 years, 6 months ago (2016-05-31 19:59:51 UTC) #53
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 21:53:21 UTC) #55
Julien Isorce Samsung
On 2016/05/25 14:11:09, Julien Isorce wrote: > On 2016/05/24 22:58:41, danakj wrote: > > On ...
4 years, 6 months ago (2016-05-31 22:21:34 UTC) #56
danakj
On 2016/05/31 22:21:34, Julien Isorce wrote: > On 2016/05/25 14:11:09, Julien Isorce wrote: > > ...
4 years, 6 months ago (2016-05-31 22:23:04 UTC) #57
piman
On 2016/05/31 22:23:04, danakj wrote: > On 2016/05/31 22:21:34, Julien Isorce wrote: > > On ...
4 years, 6 months ago (2016-05-31 22:40:09 UTC) #58
Dirk Pranke
still lgtm as well.
4 years, 6 months ago (2016-05-31 22:49:03 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008833002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008833002/130001
4 years, 6 months ago (2016-06-01 06:06:21 UTC) #61
commit-bot: I haz the power
Committed patchset #8 (id:130001)
4 years, 6 months ago (2016-06-01 06:10:13 UTC) #63
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 06:11:13 UTC) #65
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/b767ddc67b686570d12deea5576ebdbf6fa8b786
Cr-Commit-Position: refs/heads/master@{#397073}

Powered by Google App Engine
This is Rietveld 408576698