Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: testing/scripts/run_telemetry_as_googletest.py

Issue 2008833002: allow usage of transparent visuals when using xvfb (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/scripts/run_telemetry_benchmark_as_googletest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/scripts/run_telemetry_as_googletest.py
diff --git a/testing/scripts/run_telemetry_as_googletest.py b/testing/scripts/run_telemetry_as_googletest.py
index 0c111cbd8ed7c26cc466916a935d7572fd3527af..8a4cd63dd90223c96cd13c153dd02ef47bf3de5c 100755
--- a/testing/scripts/run_telemetry_as_googletest.py
+++ b/testing/scripts/run_telemetry_as_googletest.py
@@ -41,10 +41,12 @@ def main():
args, rest_args = parser.parse_known_args()
xvfb_proc = None
openbox_proc = None
+ xcompmgr_proc = None
env = os.environ.copy()
if args.xvfb and xvfb.should_start_xvfb(env):
- xvfb_proc, openbox_proc = xvfb.start_xvfb(env=env, build_dir='.')
- assert xvfb_proc and openbox_proc, 'Failed to start xvfb'
+ xvfb_proc, openbox_proc, xcompmgr_proc = xvfb.start_xvfb(env=env,
+ build_dir='.')
+ assert xvfb_proc and openbox_proc and xcompmgr_proc, 'Failed to start xvfb'
try:
with common.temporary_file() as tempfile_path:
rc = common.run_command([sys.executable] + rest_args + [
@@ -66,6 +68,7 @@ def main():
finally:
xvfb.kill(xvfb_proc)
xvfb.kill(openbox_proc)
+ xvfb.kill(xcompmgr_proc)
« no previous file with comments | « no previous file | testing/scripts/run_telemetry_benchmark_as_googletest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698