Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007833002: Delete FullscreenInfoBarDelegate class. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
Ted C, Peter Kasting
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fullscreen-android-remove-flag
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete FullscreenInfoBarDelegate class. This was previously used to display the fullscreen entry prompt on Android, but is no longer used. BUG=610900 Committed: https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1 Cr-Commit-Position: refs/heads/master@{#400367}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 6

Patch Set 3 : More cleanup suggested by Ted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -243 lines) Patch
D chrome/android/java/res/drawable-hdpi/infobar_fullscreen.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/infobar_fullscreen.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/infobar_fullscreen.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/infobar_fullscreen.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/infobar_fullscreen.png View 1 2 Binary file 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenInfoBarDelegate.java View 1 chunk +0 lines, -77 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/android/fullscreen/fullscreen_infobar_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M chrome/browser/android/resource_id.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2008813002 Patch 80001

Messages

Total messages: 18 (7 generated)
Matt Giuca
tedchoc@chromium.org: Some more cleanup around the fullscreen UI. Thanks.
4 years, 6 months ago (2016-06-08 01:37:12 UTC) #3
Ted C
https://codereview.chromium.org/2007833002/diff/20001/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc File chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc (left): https://codereview.chromium.org/2007833002/diff/20001/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc#oldcode64 chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc:64: return FULLSCREEN_INFOBAR_DELEGATE; can this be deleted? https://codereview.chromium.org/2007833002/diff/20001/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc#oldcode68 chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc:68: return ...
4 years, 6 months ago (2016-06-13 22:48:45 UTC) #4
Matt Giuca
https://codereview.chromium.org/2007833002/diff/20001/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc File chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc (left): https://codereview.chromium.org/2007833002/diff/20001/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc#oldcode64 chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc:64: return FULLSCREEN_INFOBAR_DELEGATE; On 2016/06/13 22:48:45, Ted C wrote: > ...
4 years, 6 months ago (2016-06-14 05:03:33 UTC) #5
Ted C
lgtm
4 years, 6 months ago (2016-06-14 16:26:37 UTC) #6
Matt Giuca
pkasting@chromium.org: Please review changes in infobar_delegate.h. Thanks!
4 years, 6 months ago (2016-06-15 06:10:27 UTC) #8
Peter Kasting
LGTM
4 years, 6 months ago (2016-06-15 09:18:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007833002/60001
4 years, 6 months ago (2016-06-16 00:35:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/128105)
4 years, 6 months ago (2016-06-16 02:01:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007833002/60001
4 years, 6 months ago (2016-06-17 04:16:16 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-17 05:40:35 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 05:41:51 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1
Cr-Commit-Position: refs/heads/master@{#400367}

Powered by Google App Engine
This is Rietveld 408576698