chrome/BUILD.gn - Issue 2008713003: Flip ClangToTLinux builder to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 2008713003: Flip ClangToTLinux builder to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flip_linux_memory_3

Patch Set: use full_symbols, not linux_dump_symbols Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index c66526065a4b1ae97fae471a3351b24c80cb4f0b..2f0da406227ea964ab859e2920598198cbfe8fc1 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -1495,7 +1495,7 @@ if (is_linux) {

]

}

- if (is_official_build) {

+ if (linux_dump_symbols) {

Nico 2016/05/24 22:49:58 are you sure you want to change this file still?

Dirk Pranke 2016/05/24 23:32:50 oh, bah. I thought I reverted those changes. Good

action("linux_symbols") {

script = "//build/linux/dump_app_syms.py"

« no previous file with comments | « BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »