Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: chrome/BUILD.gn

Issue 2008713003: Flip ClangToTLinux builder to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flip_linux_memory_3
Patch Set: use full_symbols, not linux_dump_symbols Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 1477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1488 1488
1489 args = [ 1489 args = [
1490 rebase_path(infile, root_build_dir), 1490 rebase_path(infile, root_build_dir),
1491 rebase_path(outfile, root_build_dir), 1491 rebase_path(outfile, root_build_dir),
1492 "-e s/@@NAME@@/$name/", 1492 "-e s/@@NAME@@/$name/",
1493 "-e s/@@FILENAME@@/$filename/", 1493 "-e s/@@FILENAME@@/$filename/",
1494 "-e s/@@CONFDIR@@/$confdir/", 1494 "-e s/@@CONFDIR@@/$confdir/",
1495 ] 1495 ]
1496 } 1496 }
1497 1497
1498 if (is_official_build) { 1498 if (linux_dump_symbols) {
Nico 2016/05/24 22:49:58 are you sure you want to change this file still?
Dirk Pranke 2016/05/24 23:32:50 oh, bah. I thought I reverted those changes. Good
1499 action("linux_symbols") { 1499 action("linux_symbols") {
1500 script = "//build/linux/dump_app_syms.py" 1500 script = "//build/linux/dump_app_syms.py"
1501 1501
1502 dump_syms_label = "//breakpad:dump_syms($host_toolchain)" 1502 dump_syms_label = "//breakpad:dump_syms($host_toolchain)"
1503 dump_syms_binary = 1503 dump_syms_binary =
1504 get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms" 1504 get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
1505 1505
1506 chrome_binary = "$root_out_dir/chrome" 1506 chrome_binary = "$root_out_dir/chrome"
1507 if (current_cpu == "x86") { 1507 if (current_cpu == "x86") {
1508 # Use "ia32" instead of "x86" for GYP compat. 1508 # Use "ia32" instead of "x86" for GYP compat.
(...skipping 30 matching lines...) Expand all
1539 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1539 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1540 "//chrome/tools/build/linux/chrome-wrapper", 1540 "//chrome/tools/build/linux/chrome-wrapper",
1541 "//third_party/xdg-utils/scripts/xdg-mime", 1541 "//third_party/xdg-utils/scripts/xdg-mime",
1542 "//third_party/xdg-utils/scripts/xdg-settings", 1542 "//third_party/xdg-utils/scripts/xdg-settings",
1543 ] 1543 ]
1544 outputs = [ 1544 outputs = [
1545 "$root_out_dir/{{source_file_part}}", 1545 "$root_out_dir/{{source_file_part}}",
1546 ] 1546 ]
1547 } 1547 }
1548 } 1548 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698