Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2008623002: [Sync] Ensure the user has a chance to change their settings on Android. (Closed)

Created:
4 years, 7 months ago by maxbogue
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Sync] Ensure the user has a chance to change their settings on Android. Using onCreate and onDestroy means that the user can go into the Google Activity Controls or Sync settings subpages without triggering sync. Note that leaving the sync page will still cause sync to start, but at that point it seems safe to assume the settings are good. BUG=613340 Review-Url: https://codereview.chromium.org/1988133005 Cr-Commit-Position: refs/heads/master@{#395081} (cherry picked from commit 0acf90ed8a771fd3129fbbca5e1ec898e0430336) Committed: https://chromium.googlesource.com/chromium/src/+/0fa795426dacf096f6f2b3b11a37c80396c4d72c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java View 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
maxbogue
4 years, 7 months ago (2016-05-23 18:58:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fa795426dacf096f6f2b3b11a37c80396c4d72c.

Powered by Google App Engine
This is Rietveld 408576698