[Sync] Ensure the user has a chance to change their settings on Android.

[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340
Committed: https://crrev.com/0acf90ed8a771fd3129fbbca5e1ec898e0430336
Cr-Commit-Position: refs/heads/master@{#395081}

[maxbogue, 2016-05-20 00:19:41]

Description was changed from

==========
[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340
==========

to

==========
[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340
==========

[maxbogue, 2016-05-20 00:20:30]

maxbogue@chromium.org changed reviewers:
+ gogerald@chromium.org, zea@chromium.org

[maxbogue, 2016-05-20 00:20:30]

Nicolas and Ganggui, PTAL at this as soon as you can!

[Nicolas Zea, 2016-05-20 00:24:28]

LGTM once patch is fixed. As a follow up CL we should add a test for this.

[gogerald1, 2016-05-20 13:10:20]

LGTM with a question. Sorry for late response, I am sheriff yesterday and today.

https://codereview.chromium.org/1988133005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
(right):

https://codereview.chromium.org/1988133005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:510:
if (pref != null) {
Curious, under what circumstance this could be null?

[maxbogue, 2016-05-20 15:53:00]

Thanks for the quick reviews, both of you!

https://codereview.chromium.org/1988133005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
(right):

https://codereview.chromium.org/1988133005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:510:
if (pref != null) {
On 2016/05/20 13:10:19, gogerald1 wrote:
> Curious, under what circumstance this could be null?

It's always null before the addPreferencesFromResource() call in update() in
onResume(). Since setting setupInProgress to true triggers syncStateChanged(), I
was hitting a NullPointerException 100% of the time in manual testing.

[maxbogue, 2016-05-20 15:53:05]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-05-20 15:53:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988133005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988133005/1

[commit-bot: I haz the power, 2016-05-20 16:09:17]

Description was changed from

==========
[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340
==========

to

==========
[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340
==========

[commit-bot: I haz the power, 2016-05-20 16:09:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-20 16:12:04]

Description was changed from

==========
[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340
==========

to

==========
[Sync] Ensure the user has a chance to change their settings on Android.

Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.

BUG=613340

Committed: https://crrev.com/0acf90ed8a771fd3129fbbca5e1ec898e0430336
Cr-Commit-Position: refs/heads/master@{#395081}
==========

[commit-bot: I haz the power, 2016-05-20 16:12:05]

Patchset 1 (id:??) landed as
https://crrev.com/0acf90ed8a771fd3129fbbca5e1ec898e0430336
Cr-Commit-Position: refs/heads/master@{#395081}