Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2008503003: Eliminate unnecessary includes of LayoutBlockFlow-derived headers. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, aboxhall, aboxhall+watch_chromium.org, blink-reviews-css, szager+layoutwatch_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, jfernandez, rjwright, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, sof, yuzo+watch_chromium.org, dmazzoni, darktears, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, nektar+watch_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-reviews-html_chromium.org, nektarios, f(malita), dtseng+watch_chromium.org, svillar, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate unnecessary includes of LayoutBlockFlow-derived headers. BUG=614015 Committed: https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a Cr-Commit-Position: refs/heads/master@{#395472}

Patch Set 1 #

Patch Set 2 : rebase master #

Patch Set 3 : styleRef(bool) needs LayoutObjectInlines.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -63 lines) Patch
M third_party/WebKit/Source/core/animation/DocumentAnimations.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/NumberInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/ClearButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBR.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutIFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVideo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mstensho (USE GERRIT)
Here's the first patch that contributes to speeding up recompilation in core/layout/ dmazzoni for modules/accessibility/ ...
4 years, 7 months ago (2016-05-23 22:04:04 UTC) #2
eae
LGTM This is great, thank you for doing this!
4 years, 7 months ago (2016-05-23 22:06:57 UTC) #3
pdr.
On 2016/05/23 at 22:06:57, eae wrote: > LGTM > > This is great, thank you ...
4 years, 7 months ago (2016-05-23 22:11:40 UTC) #4
haraken
modules/ LGTM
4 years, 7 months ago (2016-05-23 22:30:18 UTC) #5
dmazzoni
lgtm Feel free to TBR me for safe and trivial changes like this
4 years, 7 months ago (2016-05-23 23:12:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008503003/40001
4 years, 7 months ago (2016-05-23 23:56:21 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-24 00:04:37 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:06:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b4a7d5bc488ebc1b37ca3836ba697776c520115a
Cr-Commit-Position: refs/heads/master@{#395472}

Powered by Google App Engine
This is Rietveld 408576698