Convert smoothness to the new timeline based metric API.

Convert smoothness to the new timeline based metric API.

This is a reland of https://codereview.chromium.org/170183004/

BUG=345922
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257980

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258045

[nduca, 2014-03-14 20:23:45]

lgtm when you're ready

[nednguyen, 2014-03-18 16:30:11]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-18 16:35:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/1

[nednguyen, 2014-03-18 19:35:52]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-03-19 02:17:17]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-19 02:18:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/1

[commit-bot: I haz the power, 2014-03-19 02:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 02:19:04]

Failed to apply patch for tools/perf/measurements/repaint.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/measurements/repaint.py
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/perf/measurements/repaint.py.rej

Patch:       tools/perf/measurements/repaint.py
Index: tools/perf/measurements/repaint.py
diff --git a/tools/perf/measurements/repaint.py
b/tools/perf/measurements/repaint.py
index
5d2222973155c8590cc6fbb9e984b48b0113739d..0cee7a09212296167e5c2df7ba292d0385cb352b
100644
--- a/tools/perf/measurements/repaint.py
+++ b/tools/perf/measurements/repaint.py
@@ -2,31 +2,31 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-from metrics import smoothness
+from measurements import smoothness_controller
 from telemetry.page import page_measurement
 
 
 class Repaint(page_measurement.PageMeasurement):
   def __init__(self):
     super(Repaint, self).__init__('repaint', False)
-    self._smoothness_metric = None
+    self._smoothness_controller = None
 
   def CanRunForPage(self, page):
     return hasattr(page, 'repaint')
 
   def WillRunActions(self, page, tab):
     tab.WaitForDocumentReadyStateToBeComplete()
-    self._smoothness_metric = smoothness.SmoothnessMetric()
-    self._smoothness_metric.Start(page, tab)
+    self._smoothness_controller = smoothness_controller.SmoothnessController()
+    self._smoothness_controller.Start(page, tab)
     # Rasterize only what's visible.
     tab.ExecuteJavaScript(
         'chrome.gpuBenchmarking.setRasterizeOnlyVisibleContent();')
 
   def DidRunAction(self, page, tab, action):
-    self._smoothness_metric.AddActionToIncludeInMetric(action)
+    self._smoothness_controller.AddActionToIncludeInMetric(action)
 
   def DidRunActions(self, page, tab):
-    self._smoothness_metric.Stop(page, tab)
+    self._smoothness_controller.Stop(tab)
 
   def MeasurePage(self, page, tab, results):
-    self._smoothness_metric.AddResults(tab, results)
+    self._smoothness_controller.AddResults(tab, results)

[nednguyen, 2014-03-19 02:23:10]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-19 02:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/20001

[commit-bot: I haz the power, 2014-03-19 03:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 03:54:27]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nednguyen, 2014-03-19 04:05:32]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-19 04:06:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/20001

[commit-bot: I haz the power, 2014-03-19 04:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 04:54:17]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[nednguyen, 2014-03-19 05:12:57]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-19 05:13:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/20001

[nduca, 2014-03-19 10:28:35]

if this is all flake, then uncheck commit bit, put NOTRY=True, check commit
again and it'll land it.

[commit-bot: I haz the power, 2014-03-19 12:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 12:07:20]

Failed to apply patch for tools/perf/measurements/repaint.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/measurements/repaint.py
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/perf/measurements/repaint.py.rej

Patch:       tools/perf/measurements/repaint.py
Index: tools/perf/measurements/repaint.py
diff --git a/tools/perf/measurements/repaint.py
b/tools/perf/measurements/repaint.py
index
0fd4a867bd8c9578a93ee3b1cc321340df1c145e..57c5a13efbdbfb2e979280ad82e04fad399244b7
100644
--- a/tools/perf/measurements/repaint.py
+++ b/tools/perf/measurements/repaint.py
@@ -2,28 +2,28 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-from metrics import smoothness
+from measurements import smoothness_controller
 from telemetry.page import page_measurement
 
 
 class Repaint(page_measurement.PageMeasurement):
   def __init__(self):
     super(Repaint, self).__init__('repaint', False)
-    self._smoothness_metric = None
+    self._smoothness_controller = None
 
   def WillRunActions(self, page, tab):
     tab.WaitForDocumentReadyStateToBeComplete()
-    self._smoothness_metric = smoothness.SmoothnessMetric()
-    self._smoothness_metric.Start(page, tab)
+    self._smoothness_controller = smoothness_controller.SmoothnessController()
+    self._smoothness_controller.Start(page, tab)
     # Rasterize only what's visible.
     tab.ExecuteJavaScript(
         'chrome.gpuBenchmarking.setRasterizeOnlyVisibleContent();')
 
   def DidRunAction(self, page, tab, action):
-    self._smoothness_metric.AddActionToIncludeInMetric(action)
+    self._smoothness_controller.AddActionToIncludeInMetric(action)
 
   def DidRunActions(self, page, tab):
-    self._smoothness_metric.Stop(page, tab)
+    self._smoothness_controller.Stop(tab)
 
   def MeasurePage(self, page, tab, results):
-    self._smoothness_metric.AddResults(tab, results)
+    self._smoothness_controller.AddResults(tab, results)

[nednguyen, 2014-03-19 13:15:49]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-19 13:16:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/40001

[commit-bot: I haz the power, 2014-03-19 15:36:11]

Change committed as 257980

[nednguyen, 2014-03-19 16:35:17]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-03-19 16:39:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/200843002/60001

[commit-bot: I haz the power, 2014-03-19 18:42:04]

Change committed as 258045