Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: tools/perf/metrics/timeline.py

Issue 200843002: Convert smoothness to the new timeline based metric API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/metrics/smoothness_unittest.py ('k') | tools/perf/metrics/timeline_based_metric.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/timeline.py
diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py
index 9313d99fe6aba852c87659d12267f433f217ea21..89b1b7f336c799455c7a14ef5f6b374d4db5f1a1 100644
--- a/tools/perf/metrics/timeline.py
+++ b/tools/perf/metrics/timeline.py
@@ -51,7 +51,12 @@ class TimelineMetric(Metric):
if self._mode == TRACING_MODE:
if not tab.browser.supports_tracing:
raise Exception('Not supported')
- tab.browser.StartTracing(self.trace_categories)
+ if self.trace_categories:
+ categories = [self.trace_categories] + \
+ page.GetSyntheticDelayCategories()
+ else:
+ categories = page.GetSyntheticDelayCategories()
+ tab.browser.StartTracing(','.join(categories))
else:
assert self._mode == TIMELINE_MODE
tab.StartTimelineRecording()
« no previous file with comments | « tools/perf/metrics/smoothness_unittest.py ('k') | tools/perf/metrics/timeline_based_metric.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698