Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2008403002: [Mac][Material Design] Restore apps page shortcut icon in bookmarks bar. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Restore apps page shortcut icon in bookmarks bar. A recent bookmarks bar change caused the apps page shortcut button to display a document icon instead of the 9 colored dots icon. R=avi@chromium.org BUG=613458 Review-Url: https://codereview.chromium.org/2007103002 Cr-Commit-Position: refs/heads/master@{#395669} (cherry picked from commit 4faf1132c3d418b065d5600b8ed07f4175b15bfe) Committed: https://chromium.googlesource.com/chromium/src/+/751ce64520b7f5e38053fab2b56c47a4ca12de8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shrike
4 years, 7 months ago (2016-05-25 18:28:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
751ce64520b7f5e38053fab2b56c47a4ca12de8d.

Powered by Google App Engine
This is Rietveld 408576698