Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2007103002: [Mac][Material Design] Restore apps page shortcut icon in bookmarks bar. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Restore apps page shortcut icon in bookmarks bar. A recent bookmarks bar change caused the apps page shortcut button to display a document icon instead of the 9 colored dots icon. R=avi@chromium.org BUG=613458 Committed: https://crrev.com/4faf1132c3d418b065d5600b8ed07f4175b15bfe Cr-Commit-Position: refs/heads/master@{#395669}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
shrike
PTAL
4 years, 6 months ago (2016-05-24 17:37:31 UTC) #1
Avi (use Gerrit)
lgtm https://codereview.chromium.org/2007103002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h (right): https://codereview.chromium.org/2007103002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h#newcode403 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h:403: // Returns the app page shortcut button/ period ...
4 years, 6 months ago (2016-05-24 18:04:33 UTC) #2
shrike
https://codereview.chromium.org/2007103002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h (right): https://codereview.chromium.org/2007103002/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h#newcode403 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h:403: // Returns the app page shortcut button/ On 2016/05/24 ...
4 years, 6 months ago (2016-05-24 18:06:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007103002/20001
4 years, 6 months ago (2016-05-24 18:07:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-24 19:13:18 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-24 19:14:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4faf1132c3d418b065d5600b8ed07f4175b15bfe
Cr-Commit-Position: refs/heads/master@{#395669}

Powered by Google App Engine
This is Rietveld 408576698