Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2008283004: Revert of Added a debug info UI for Blimp (Closed)

Created:
4 years, 7 months ago by haibinlu
Modified:
4 years, 7 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added a debug info UI for Blimp (patchset #12 id:220001 of https://codereview.chromium.org/1962393004/ ) Reason for revert: crbug.com/614888 broken blimp browsertest on fyi bot. Original issue's description: > Added a debug info UI for Blimp > > Added a menu option in toolbar to show/hide debug info. When enabled, > an overlay debug UI would be shown on the bottom left of the screen > showing number of commits, and kilobytes sent and received by the client. > This data is reset when the user moves away or is redirected to a new > page. > > BUG=594423 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/03e5b0d97aa1fc6e813725465142978896ed8641 > Cr-Commit-Position: refs/heads/master@{#395931} TBR=kmarshall@chromium.org,khushalsagar@chromium.org,vmpstr@chromium.org,shaktisahu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594423 Committed: https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361 Cr-Commit-Position: refs/heads/master@{#396073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -766 lines) Patch
M blimp/client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/app/android/blimp_client_session_android.h View 2 chunks +0 lines, -7 lines 0 comments Download
M blimp/client/app/android/blimp_client_session_android.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M blimp/client/app/android/blimp_view.h View 4 chunks +1 line, -7 lines 0 comments Download
M blimp/client/app/android/blimp_view.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M blimp/client/app/android/java/res/layout/blimp_main.xml View 1 chunk +10 lines, -18 lines 0 comments Download
D blimp/client/app/android/java/res/layout/debug_stats_overlay.xml View 1 chunk +0 lines, -50 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java View 8 chunks +6 lines, -79 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java View 2 chunks +0 lines, -17 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java View 8 chunks +99 lines, -45 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/toolbar/ToolbarMenu.java View 1 chunk +0 lines, -195 lines 0 comments Download
M blimp/client/app/android/java/strings/android_blimp_strings.grd View 1 chunk +0 lines, -15 lines 0 comments Download
M blimp/client/app/linux/blimp_display_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/app/linux/blimp_display_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/session/blimp_client_session.h View 3 chunks +0 lines, -7 lines 0 comments Download
M blimp/client/session/blimp_client_session.cc View 5 chunks +11 lines, -24 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 3 chunks +1 line, -4 lines 0 comments Download
M blimp/net/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M blimp/net/blimp_connection.h View 2 chunks +1 line, -2 lines 0 comments Download
M blimp/net/blimp_connection.cc View 3 chunks +6 lines, -1 line 0 comments Download
D blimp/net/blimp_connection_statistics.h View 1 chunk +0 lines, -48 lines 0 comments Download
D blimp/net/blimp_connection_statistics.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D blimp/net/blimp_connection_statistics_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M blimp/net/ssl_client_transport.h View 2 chunks +0 lines, -2 lines 0 comments Download
M blimp/net/ssl_client_transport.cc View 1 chunk +1 line, -3 lines 0 comments Download
M blimp/net/ssl_client_transport_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M blimp/net/stream_packet_reader.h View 3 chunks +1 line, -6 lines 0 comments Download
M blimp/net/stream_packet_reader.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M blimp/net/stream_packet_reader_unittest.cc View 6 chunks +3 lines, -11 lines 0 comments Download
M blimp/net/stream_packet_writer.h View 3 chunks +1 line, -6 lines 0 comments Download
M blimp/net/stream_packet_writer.cc View 3 chunks +1 line, -7 lines 0 comments Download
M blimp/net/stream_packet_writer_unittest.cc View 6 chunks +3 lines, -10 lines 0 comments Download
M blimp/net/stream_socket_connection.h View 1 chunk +1 line, -3 lines 0 comments Download
M blimp/net/stream_socket_connection.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M blimp/net/tcp_client_transport.h View 2 chunks +1 line, -5 lines 0 comments Download
M blimp/net/tcp_client_transport.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M blimp/net/tcp_engine_transport.h View 2 chunks +2 lines, -6 lines 0 comments Download
M blimp/net/tcp_engine_transport.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M blimp/net/tcp_transport_unittest.cc View 5 chunks +5 lines, -12 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/remote_channel_impl.cc View 2 chunks +1 line, -11 lines 0 comments Download
M cc/trees/remote_channel_unittest.cc View 2 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
haibinlu
Created Revert of Added a debug info UI for Blimp
4 years, 7 months ago (2016-05-26 01:11:47 UTC) #1
haibinlu
4 years, 7 months ago (2016-05-26 01:11:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008283004/1
4 years, 7 months ago (2016-05-26 01:12:34 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-26 01:12:37 UTC) #5
Kevin M
lgtm
4 years, 7 months ago (2016-05-26 01:13:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008283004/1
4 years, 7 months ago (2016-05-26 01:14:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 01:15:33 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 01:16:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/955c7d93dd9852ae93a3d8e9b1fd396c37baf361
Cr-Commit-Position: refs/heads/master@{#396073}

Powered by Google App Engine
This is Rietveld 408576698