Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2742)

Unified Diff: blimp/net/stream_packet_reader_unittest.cc

Issue 2008283004: Revert of Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/stream_packet_reader.cc ('k') | blimp/net/stream_packet_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/stream_packet_reader_unittest.cc
diff --git a/blimp/net/stream_packet_reader_unittest.cc b/blimp/net/stream_packet_reader_unittest.cc
index 3341a673f982bc2b5991c047c4aecf6f8cdaa57f..a076a41c5eac2ca09f5d04ef00152b6cbcf9e9f2 100644
--- a/blimp/net/stream_packet_reader_unittest.cc
+++ b/blimp/net/stream_packet_reader_unittest.cc
@@ -7,7 +7,6 @@
#include "base/message_loop/message_loop.h"
#include "base/sys_byteorder.h"
-#include "blimp/net/blimp_connection_statistics.h"
#include "blimp/net/common.h"
#include "blimp/net/stream_packet_reader.h"
#include "blimp/net/test_common.h"
@@ -35,7 +34,7 @@
StreamPacketReaderTest()
: buffer_(new net::GrowableIOBuffer),
test_msg_("U WOT M8"),
- data_reader_(&socket_, &statistics_) {}
+ data_reader_(&socket_) {}
~StreamPacketReaderTest() override {}
@@ -48,7 +47,6 @@
net::TestCompletionCallback callback_;
testing::StrictMock<MockStreamSocket> socket_;
testing::InSequence sequence_;
- BlimpConnectionStatistics statistics_;
StreamPacketReader data_reader_;
};
@@ -158,13 +156,9 @@
ReadPacket();
ASSERT_EQ(static_cast<int>(test_msg_.size()), callback_.WaitForResult());
- EXPECT_EQ(static_cast<int>(test_msg_.size()),
- statistics_.Get(BlimpConnectionStatistics::BYTES_RECEIVED));
ReadPacket();
ASSERT_EQ(static_cast<int>(test_msg2.size()), callback_.WaitForResult());
- EXPECT_EQ(static_cast<int>(test_msg_.size() + test_msg2.size()),
- statistics_.Get(BlimpConnectionStatistics::BYTES_RECEIVED));
EXPECT_TRUE(BufferStartsWith(buffer_.get(), test_msg2.size(), test_msg2));
EXPECT_FALSE(callback_.have_result());
@@ -319,8 +313,7 @@
TEST_F(StreamPacketReaderTest, ReaderDeletedDuringAsyncHeaderRead) {
net::CompletionCallback cb;
net::TestCompletionCallback test_cb;
- std::unique_ptr<StreamPacketReader> reader(
- new StreamPacketReader(&socket_, &statistics_));
+ std::unique_ptr<StreamPacketReader> reader(new StreamPacketReader(&socket_));
EXPECT_CALL(socket_, Read(NotNull(), kPacketHeaderSizeBytes, _))
.WillOnce(DoAll(FillBufferFromString<0>(EncodeHeader(test_msg_.size())),
@@ -335,8 +328,7 @@
// StreamPacketReader object was destroyed.
TEST_F(StreamPacketReaderTest, ReaderDeletedDuringAsyncPayloadRead) {
net::CompletionCallback cb;
- std::unique_ptr<StreamPacketReader> reader(
- new StreamPacketReader(&socket_, &statistics_));
+ std::unique_ptr<StreamPacketReader> reader(new StreamPacketReader(&socket_));
EXPECT_CALL(socket_, Read(NotNull(), kPacketHeaderSizeBytes, _))
.WillOnce(DoAll(FillBufferFromString<0>(EncodeHeader(test_msg_.size())),
« no previous file with comments | « blimp/net/stream_packet_reader.cc ('k') | blimp/net/stream_packet_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698