Tool to generate screenshots of Chrome in various languages

Tool to generate screenshots of Chrome in various languages

This tool allows us to easily create the same screenshot of a certain setup in
all languages that are supported by Chrome (e.g. "Take a screenshot of the UMA
settings in all languages.").

BUG=614676

[battre, 2016-05-25 11:11:34]

battre@chromium.org changed reviewers:
+ melandory@chromium.org

[battre, 2016-05-25 11:11:35]

Hi Tanja,

could you please review this CL?

Thanks,
Dominic

[melandory, 2016-05-30 12:17:39]

On 2016/05/25 11:11:35, battre wrote:
> Hi Tanja,
> 
> could you please review this CL?
> 
> Thanks,
> Dominic

LGTM+nits

[melandory, 2016-05-30 13:51:49]

https://codereview.chromium.org/2008283002/diff/1/tools/privacy_whitepaper/en...
File tools/privacy_whitepaper/environment.py (right):

https://codereview.chromium.org/2008283002/diff/1/tools/privacy_whitepaper/en...
tools/privacy_whitepaper/environment.py:105: pyautogui.click(x = 746, y = 62)
nit: pyautogui.click( x = 57 if self.is_rtl_language else 62
                 y = 62)?

It's up to you, but I think python form of ternary operator makes it very
readable.

https://codereview.chromium.org/2008283002/diff/1/tools/privacy_whitepaper/ge...
File tools/privacy_whitepaper/generate_screenshots.py (right):

https://codereview.chromium.org/2008283002/diff/1/tools/privacy_whitepaper/ge...
tools/privacy_whitepaper/generate_screenshots.py:64:
self.GoTo("https://www.amazon.co.jp")
nit: I would make website prefix a class member, just to simplify editing in a
future in case one wanted to take screenshot of google.fr or google.co.jp. But
ignore if you think that readability of the current solution wins other
potentially non-existent problem I'm suggesting to solve :)

https://codereview.chromium.org/2008283002/diff/1/tools/privacy_whitepaper/sc...
File tools/privacy_whitepaper/screenshot_generator.py (right):

https://codereview.chromium.org/2008283002/diff/1/tools/privacy_whitepaper/sc...
tools/privacy_whitepaper/screenshot_generator.py:41: logging.log(SCRIPT_DEBUG,
"action: Click %s" % selector)
nit:
since it's python and you're using same pattern in many places (log+wait for
element), you can write decorator:
def LogAndWait(f):
  from functools import wraps
  @wraps(f)
  def wrapper(self, selector):
    logging.log(SCRIPT_DEBUG, "action: %s %s" % (f.__name__, selector))
    element = self.WaitUntilDisplayed(selector)
    return f(self, element)
  return wrapper

And then
@LogAndWait
def Click(self, element)

[vabr (Chromium), 2016-08-20 19:22:29]

Description was changed from

==========
Tool to generate screenshots of Chrome in various languages

This tool allows us to easily create the same screenshot of a certain setup in
all languages that are supported by Chrome (e.g. "Take a screenshot of the UMA
settings in all languages.").

BUG=614676
==========

to

==========
Tool to generate screenshots of Chrome in various languages

This tool allows us to easily create the same screenshot of a certain setup in
all languages that are supported by Chrome (e.g. "Take a screenshot of the UMA
settings in all languages.").

BUG=614676
==========