Chromium Code Reviews Chromium Code Reviews
Issue 2008253004:
Refactor rel32 searching process for x64 to make it more similar to x86. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: courgette/testdata/rel32_x64_03.txt |
| diff --git a/courgette/testdata/rel32_win32_x86_03.txt b/courgette/testdata/rel32_x64_03.txt |
| similarity index 60% |
| copy from courgette/testdata/rel32_win32_x86_03.txt |
| copy to courgette/testdata/rel32_x64_03.txt |
| index 6403b103caa0e3728ef0b7e6c7619d80a67f8ebb..8d7c7b291be0e76465fc5ea605d735f407d56016 100644 |
| --- a/courgette/testdata/rel32_win32_x86_03.txt |
| +++ b/courgette/testdata/rel32_x64_03.txt |
| @@ -28,8 +28,21 @@ Program: |
| 00401039: E8 C2 3F 00 00 call 00405000 # Outside image |
| 0040103E: E8 BE 3F 00 00 call 00405001 # Outside image |
| 00401043: E8 88 88 88 88 call 88C898D0 # Far away |
| - 00401048: 5D pop ebp |
| - 00401049: C3 ret |
| + 00401048: FF 15 B1 EF FF FF call 003FFFFF # 1 byte before image |
|
huangs
2016/05/26 22:40:55
NIT: align #
etiennep
2016/05/27 18:12:34
Done.
|
| + 0040104E: FF 15 AC EF FF FF call 00400000 # In image |
| + 00401054: FF 15 A5 3F 00 00 call 00404FFF # 1 byte before end of image |
|
huangs
2016/05/26 22:40:55
If you're concerned with wrapping:
# 1 byte before
etiennep
2016/05/27 18:12:34
Done.
|
| + 0040105A: FF 15 A0 3F 00 00 call 00405000 # Outside image |
| + 00401060: FF 15 6A 88 C8 88 call 88C898D0 # Far away |
| + 00401066: FF 25 93 EF FF FF jmp 003FFFFF |
| + 0040106C: FF 25 8E EF FF FF jmp 00400000 |
| + 00401072: FF 25 87 3F 00 00 jmp 00404FFF |
| + 00401078: FF 25 82 3F 00 00 jmp 00405000 |
| + 0040107E: 8D 05 7B EF FF FF lea eax, 003FFFFF |
| + 00401084: 8D 05 76 EF FF FF lea eax, 00400000 |
| + 0040108A: 8D 05 6F 3F 00 00 lea eax, 00404FFF |
| + 00401090: 8D 05 6A 3F 00 00 lea eax, 00405000 |
| + 00401096: 5D pop ebp |
| + 00401097: C3 ret |
| Abs32: |
| @@ -38,3 +51,9 @@ Expected: |
| 1015 |
| 101F |
| 102A |
| +1050 |
| +1056 |
| +106E |
| +1074 |
| +#1086 |
| +#108C |
