courgette/testdata/rel32_x64_02.txt - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/testdata/rel32_x64_02.txt

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rollback to original courgette algorithm and improve unittests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/testdata/rel32_x64_02.txt

diff --git a/courgette/testdata/rel32_win32_x86_02.txt b/courgette/testdata/rel32_x64_02.txt

similarity index 63%

copy from courgette/testdata/rel32_win32_x86_02.txt

copy to courgette/testdata/rel32_x64_02.txt

index a9e5b1283d7f674088c00d2682dd496e71a7140d..f06d15b5ac6d95e29fad7ddb08065c7727ed2b78 100644

--- a/courgette/testdata/rel32_win32_x86_02.txt

+++ b/courgette/testdata/rel32_x64_02.txt

@@ -34,8 +34,30 @@ Program:

0040105B: 0F 8D 00 00 00 00 jge 00401061 # Overlaps with abs32

00401061: 0F 8E 00 00 00 00 jle 00401067

00401067: 0F 8F 00 00 00 00 jg 0040106D

- 0040106D: 5D pop ebp

- 0040106E: C3 ret

+ 0040106D: FF 15 00 00 00 00 call 00401073

+ 00401073: FF 25 00 00 00 00 jmp 00401079

+ 00401079: 8B 05 00 00 00 00 mov eax, 00401079

+ 0040107F: 8B 3D 00 00 00 00 mov edi, 00401085

+ 00401085: 8D 05 00 00 00 00 lea eax, 00401079

+ 0040108B: 8D 3D 00 00 00 00 lea edi, 00401079

+ 00401091: 48 8B 05 00 00 00 mov rax, 00401098

+ 00

+ 00401098: 48 8B 3D 00 00 00 mov rdi, 0040109F

+ 00

+ 0040109F: 48 8D 05 00 00 00 lea rax, 004010A6

+ 00

+ 004010A6: 48 8D 3D 00 00 00 lea rdi, 004010AD

+ 00

+ 004010AD: 4C 8B 05 00 00 00 mov r8, 004010B4

+ 00

+ 004010B4: 4C 8B 3D 00 00 00 mov r15, 004010BB

+ 00

+ 004010BB: 4C 8D 05 00 00 00 lea r8, 004010C2

+ 00

+ 004010C2: 4C 8D 3D 00 00 00 lea r15, 004010C9

+ 00

+ 004010C9: 5D pop ebp

+ 004010CA: C3 ret

Abs32:

1004

@@ -58,5 +80,19 @@ Expected:

1045

# 1057

# 105D

-1063 # Op code 0F 8E overlaps with abs32 105F, but still okay

+1063

1069

+106F

+1075

+#107B

huangs 2016/05/26 22:40:55 NIT: Space after "#" for consistency. Also update

etiennep 2016/05/27 18:12:34 Done.

+#1081

+#1087

+#108D

+1094

+109B

+10A2

+10A9

+10B0

+10B7

+10BE

+10C5

« courgette/rel32_finder_x86.h ('K') | « courgette/testdata/rel32_x64_01.txt ('k') | courgette/testdata/rel32_x64_03.txt » ('j') | courgette/testdata/rel32_x64_03.txt » ('J')