components/mus/gles2/command_buffer_local.cc - Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/gles2/command_buffer_local.cc

Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/mus/gles2/command_buffer_local.h ('k') | components/mus/gpu/gpu_service_mus.h » ('j') | components/mus/public/cpp/lib/command_buffer_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/gles2/command_buffer_local.cc

diff --git a/components/mus/gles2/command_buffer_local.cc b/components/mus/gles2/command_buffer_local.cc

index 971ccec6eb7fb49c2589662779465d63e457b147..e9275058aef393c66a11a6562966d7d45fd758d3 100644

--- a/components/mus/gles2/command_buffer_local.cc

+++ b/components/mus/gles2/command_buffer_local.cc

@@ -233,9 +233,7 @@ int32_t CommandBufferLocal::CreateImage(ClientBuffer buffer,

unsigned internal_format) {

DCHECK(CalledOnValidThread());

int32_t new_id = ++next_image_id_;

- mojo::SizePtr size = mojo::Size::New();

- size->width = static_cast<int32_t>(width);

- size->height = static_cast<int32_t>(height);

+ gfx::Size size(static_cast<int32_t>(width), static_cast<int32_t>(height));

mus::MojoGpuMemoryBufferImpl* gpu_memory_buffer =

mus::MojoGpuMemoryBufferImpl::FromClientBuffer(buffer);

@@ -503,7 +501,7 @@ bool CommandBufferLocal::CreateImageOnGpuThread(

int32_t id,

mojo::ScopedHandle memory_handle,

int32_t type,

- mojo::SizePtr size,

+ const gfx::Size& size,

int32_t format,

int32_t internal_format) {

DCHECK(driver_->IsScheduled());