components/mus/public/cpp/lib/command_buffer_client_impl.cc - Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/lib/command_buffer_client_impl.cc

Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/mus/public/cpp/BUILD.gn ('k') | components/mus/public/cpp/lib/window.cc » ('j') | components/mus/public/cpp/lib/window_tree_client_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/cpp/lib/command_buffer_client_impl.cc

diff --git a/components/mus/public/cpp/lib/command_buffer_client_impl.cc b/components/mus/public/cpp/lib/command_buffer_client_impl.cc

index ebbee055ca086f572a6cf2934775d996fc7b292b..5fd454a1a1703f3a695394ae1c3849983c7d3c7d 100644

--- a/components/mus/public/cpp/lib/command_buffer_client_impl.cc

+++ b/components/mus/public/cpp/lib/command_buffer_client_impl.cc

@@ -213,9 +213,7 @@ int32_t CommandBufferClientImpl::CreateImage(ClientBuffer buffer,

unsigned internalformat) {

int32_t new_id = ++next_image_id_;

- mojo::SizePtr size = mojo::Size::New();

- size->width = static_cast<int32_t>(width);

- size->height = static_cast<int32_t>(height);

+ gfx::Size size(static_cast<int32_t>(width), static_cast<int32_t>(height));

dcheng 2016/05/26 22:20:40 Not related to your change but I wonder why this f

mus::MojoGpuMemoryBufferImpl* gpu_memory_buffer =

mus::MojoGpuMemoryBufferImpl::FromClientBuffer(buffer);

« no previous file with comments | « components/mus/public/cpp/BUILD.gn ('k') | components/mus/public/cpp/lib/window.cc » ('j') | components/mus/public/cpp/lib/window_tree_client_impl.cc » ('J')