Fix capturing variables in optimized compilations

Fix capturing variables in optimized compilations

Third attempt. A latent bug in finally block inlining
caused the previous crashes in optimized functions.
Fix is in https://codereview.chromium.org/2004883004/.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/4dca5d0e012756faa08991c55098f8a566968e63

[hausner, 2016-05-24 19:12:15]

Description was changed from

==========
Fix capturing variables in optimized compilations

Third attempt. A latent bug in finally block inlining
caused the previous crashes in optimized functions.
Fix is in https://codereview.chromium.org/2004883004/.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

to

==========
Fix capturing variables in optimized compilations

Third attempt. A latent bug in finally block inlining
caused the previous crashes in optimized functions.
Fix is in https://codereview.chromium.org/2004883004/.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

[hausner, 2016-05-24 19:12:15]

hausner@google.com changed reviewers:
+ rmacnak@google.com

[hausner, 2016-05-24 19:52:42]

Third time's a charm, hopefully.

[rmacnak, 2016-05-24 21:17:09]

lgtm

[hausner, 2016-05-24 21:40:56]

Description was changed from

==========
Fix capturing variables in optimized compilations

Third attempt. A latent bug in finally block inlining
caused the previous crashes in optimized functions.
Fix is in https://codereview.chromium.org/2004883004/.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

to

==========
Fix capturing variables in optimized compilations

Third attempt. A latent bug in finally block inlining
caused the previous crashes in optimized functions.
Fix is in https://codereview.chromium.org/2004883004/.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4dca5d0e012756faa08991c55098f8a566968e63
==========

[hausner, 2016-05-24 21:40:57]

Committed patchset #1 (id:1) manually as
4dca5d0e012756faa08991c55098f8a566968e63 (presubmit successful).