Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2004883004: Fix latent bug in finally-block inlining (Closed)

Created:
4 years, 7 months ago by hausner
Modified:
4 years, 7 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix latent bug in finally-block inlining The parser copies blocks of finally clauses to every return or jump statement that can break out of enclosing try statements. This change makes sure that only enclosing try statements in the same function are considered. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/b88c77759071138bb4687451f70be6030bb7dd5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/vm/parser.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
This bug bit me in my previous CL where I eliminate parsing inner functions. I'm ...
4 years, 7 months ago (2016-05-23 23:09:34 UTC) #3
Florian Schneider
LGTM
4 years, 7 months ago (2016-05-24 06:45:52 UTC) #4
hausner
4 years, 7 months ago (2016-05-24 15:51:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b88c77759071138bb4687451f70be6030bb7dd5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698