third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp - Issue 2007823002: Fix whitespace handling in parseSimpleTransformList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

Issue 2007823002: Fix whitespace handling in parseSimpleTransformList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: only transform tests for now. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h ('k') | third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

index 33a29e13cf63751eac303eef181606efce2df827..2fc2a0c8185e4acd717d354e62ad42e334ca5684 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -993,16 +993,14 @@ static CSSValueList* parseSimpleTransformList(CharType*& pos, CharType* end)

while (pos < end) {

while (pos < end && isCSSSpace(*pos))

++pos;

+ if (pos >= end)

+ break;

CSSFunctionValue* transformValue = parseSimpleTransformValue(pos, end);

if (!transformValue)

return nullptr;

if (!transformList)

transformList = CSSValueList::createSpaceSeparated();

transformList->append(transformValue);

- if (pos < end) {

- if (isCSSSpace(*pos))

- return nullptr;

- }

}

return transformList;

}