Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007813003: Remove Mojo GLES2 API (Closed)

Created:
4 years, 7 months ago by Peng
Modified:
4 years, 6 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, rjkroege, chromium-apps-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, extensions-reviews_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Mojo GLES2 API BUG=586390 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/2da58ddae3d57687285fb760f7a091140d172ebd Cr-Commit-Position: refs/heads/master@{#395895}

Patch Set 1 #

Patch Set 2 : Update #

Total comments: 2

Patch Set 3 : Update #

Patch Set 4 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1620 lines) Patch
M WATCHLISTS View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/bitmap_uploader/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 2 7 chunks +22 lines, -42 lines 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/context_provider.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/public/cpp/gles2_context.h View 1 3 chunks +2 lines, -11 lines 0 comments Download
M components/mus/public/cpp/lib/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/lib/context_provider.cc View 2 chunks +1 line, -5 lines 0 comments Download
M components/mus/public/cpp/lib/gles2_context.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 6 chunks +0 lines, -125 lines 0 comments Download
M mash/wm/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D mojo/gles2/BUILD.gn View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/gles2/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/gles2/README.md View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/gles2/gles2_impl.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D mojo/public/c/gles2/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/public/c/gles2/chromium_extension.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/public/c/gles2/gles2.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/public/c/gles2/gles2_call_visitor_autogen.h View 1 chunk +0 lines, -537 lines 0 comments Download
D mojo/public/c/gles2/gles2_call_visitor_chromium_extension_autogen.h View 1 chunk +0 lines, -564 lines 0 comments Download
D mojo/public/c/gles2/gles2_export.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/public/c/gles2/gles2_types.h View 1 chunk +0 lines, -25 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peng
Hi piman & sky, PTAL. Thanks.
4 years, 7 months ago (2016-05-24 19:27:50 UTC) #3
sky
LGTM
4 years, 7 months ago (2016-05-24 20:46:05 UTC) #4
piman
LGTM! https://codereview.chromium.org/2007813003/diff/20001/components/bitmap_uploader/bitmap_uploader.cc File components/bitmap_uploader/bitmap_uploader.cc (right): https://codereview.chromium.org/2007813003/diff/20001/components/bitmap_uploader/bitmap_uploader.cc#newcode52 components/bitmap_uploader/bitmap_uploader.cc:52: CHECK(gles2_context_->Initialize()); nit: DCHECK
4 years, 7 months ago (2016-05-24 21:25:08 UTC) #5
Peng
https://codereview.chromium.org/2007813003/diff/20001/components/bitmap_uploader/bitmap_uploader.cc File components/bitmap_uploader/bitmap_uploader.cc (right): https://codereview.chromium.org/2007813003/diff/20001/components/bitmap_uploader/bitmap_uploader.cc#newcode52 components/bitmap_uploader/bitmap_uploader.cc:52: CHECK(gles2_context_->Initialize()); On 2016/05/24 21:25:07, piman wrote: > nit: DCHECK ...
4 years, 7 months ago (2016-05-25 14:21:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007813003/60001
4 years, 7 months ago (2016-05-25 14:35:30 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-25 15:58:03 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 15:59:45 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2da58ddae3d57687285fb760f7a091140d172ebd
Cr-Commit-Position: refs/heads/master@{#395895}

Powered by Google App Engine
This is Rietveld 408576698