Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2007773002: QUIC - Pass remote_address_ if address is not specified in UDPSocketWin::Write() (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

QUIC - Pass remote_address_ if address is not specified in UDPSocketWin::Write() call. WSASendTo API call requires address and tsvipcli.dll crashes if address is NULL. Revered the changes to disable QUIC when tsvipcli.dll is loaded. https://codereview.chromium.org/1999893002/ BUG=471986 R=rch@chromium.org Review-Url: https://codereview.chromium.org/2002713003 Cr-Commit-Position: refs/heads/master@{#395237} (cherry picked from commit b01cd3b37e9daff57a621bcd6efd640cddac6d1e) Committed: https://chromium.googlesource.com/chromium/src/+/51f2b2e951800554341eff0aaef115255be12fc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M net/quic/quic_stream_factory.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/udp/udp_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
ramant (doing other things)
4 years, 7 months ago (2016-05-23 23:35:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51f2b2e951800554341eff0aaef115255be12fc3.

Powered by Google App Engine
This is Rietveld 408576698