content/renderer/media/renderer_gpu_video_accelerator_factories.cc - Issue 200763011: Add explicit flush after copyTextureCHROMIUM to make the change visible accross contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_gpu_video_accelerator_factories.cc

Issue 200763011: Add explicit flush after copyTextureCHROMIUM to make the change visible accross contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/android/webmediaplayer_android.cc ('K') | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/webmediaplayer_impl.cc » ('j') | content/renderer/media/webmediaplayer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_gpu_video_accelerator_factories.cc

diff --git a/content/renderer/media/renderer_gpu_video_accelerator_factories.cc b/content/renderer/media/renderer_gpu_video_accelerator_factories.cc

index f51bd42302bcde2aaae2135e54a9de2e92bf95eb..68bd709ec3e6b978d3aa21676c5f177a0fd8c66c 100644

--- a/content/renderer/media/renderer_gpu_video_accelerator_factories.cc

+++ b/content/renderer/media/renderer_gpu_video_accelerator_factories.cc

@@ -186,6 +186,7 @@ void RendererGpuVideoAcceleratorFactories::ReadPixels(

gles2->TexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);

context->copyTextureCHROMIUM(

GL_TEXTURE_2D, texture_id, tmp_texture, 0, GL_RGBA, GL_UNSIGNED_BYTE);

+ context->flush();

no sievers 2014/03/18 22:47:32 Do we need this one? We are reading back the textu

junj 2014/03/19 07:47:37 Yes, the flush() is not needed here. I made a mist

GLuint fb;

gles2->GenFramebuffers(1, &fb);