Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2007593005: Remove the concept of OutputSurface from ResourceProvider. (Closed)

Created:
4 years, 7 months ago by danakj
Modified:
4 years, 7 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), Fady Samuel, piman, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the concept of OutputSurface from ResourceProvider. Pass around the compositor and worker context providers as needed instead of grabbing them from ResourceProvider. ResourceProvider is used by both the collator and the compositor but only one of those will use OutputSurface eventually. This allows easier use of ResourceProvider in test harnesses for now also. R=piman@chromium.org, reveman@chromium.org BUG=311404, 606056 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0de0c95afd3ddeca195dc6b374aa75b5ee24d776 Cr-Commit-Position: refs/heads/master@{#395769}

Patch Set 1 #

Patch Set 2 : resourceprovider-no-outputsurface: . #

Patch Set 3 : resourceprovider-no-outputsurface: rebase #

Patch Set 4 : resourceprovider-no-outputsurface: ccperftestcompile #

Patch Set 5 : resourceprovider-no-outputsurface: bool #

Patch Set 6 : resourceprovider-no-outputsurface: moreccptcompile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -446 lines) Patch
M cc/raster/gpu_raster_buffer_provider.h View 2 chunks +6 lines, -11 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 3 chunks +10 lines, -25 lines 0 comments Download
M cc/raster/gpu_rasterizer.h View 1 chunk +6 lines, -2 lines 0 comments Download
M cc/raster/gpu_rasterizer.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.h View 5 chunks +12 lines, -18 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 8 chunks +18 lines, -34 lines 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 1 2 3 4 5 5 chunks +16 lines, -9 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M cc/raster/staging_buffer_pool.h View 3 chunks +6 lines, -10 lines 0 comments Download
M cc/raster/staging_buffer_pool.cc View 4 chunks +5 lines, -21 lines 0 comments Download
M cc/resources/resource.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/resource_provider.h View 1 2 3 4 6 chunks +17 lines, -27 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 4 10 chunks +88 lines, -120 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 2 3 4 28 chunks +133 lines, -108 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 3 4 1 chunk +8 lines, -10 lines 0 comments Download
M cc/test/fake_resource_provider.h View 1 2 3 4 3 chunks +11 lines, -9 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 3 chunks +15 lines, -10 lines 0 comments Download
M cc/test/pixel_test.cc View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 chunks +21 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (10 generated)
danakj
4 years, 7 months ago (2016-05-24 01:49:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007593005/1
4 years, 7 months ago (2016-05-24 01:50:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007593005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007593005/20001
4 years, 7 months ago (2016-05-24 01:52:50 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/217179) linux_chromium_rel_ng on ...
4 years, 7 months ago (2016-05-24 02:11:04 UTC) #10
piman
LGTM % compile errors
4 years, 7 months ago (2016-05-24 17:33:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007593005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007593005/100001
4 years, 7 months ago (2016-05-24 23:34:21 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-25 01:43:03 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 01:47:19 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/0de0c95afd3ddeca195dc6b374aa75b5ee24d776
Cr-Commit-Position: refs/heads/master@{#395769}

Powered by Google App Engine
This is Rietveld 408576698