Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: services/shell/public/cpp/lib/interface_provider.cc

Issue 2007473004: [Autofill] Migrate ContentAutofillDriver<-->AutofillAgent IPCs to mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase only Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shell/public/cpp/lib/interface_provider.cc
diff --git a/services/shell/public/cpp/lib/interface_provider.cc b/services/shell/public/cpp/lib/interface_provider.cc
index 209d356ac476bb6a79d8cfc51f389500c8b297b7..63a8753e5a3127348fcf7f70c1b66dfaeb6c4ab3 100644
--- a/services/shell/public/cpp/lib/interface_provider.cc
+++ b/services/shell/public/cpp/lib/interface_provider.cc
@@ -19,7 +19,8 @@ void InterfaceProvider::Bind(mojom::InterfaceProviderPtr interface_provider) {
void InterfaceProvider::SetConnectionLostClosure(
const base::Closure& connection_lost_closure) {
- interface_provider_.set_connection_error_handler(connection_lost_closure);
+ if (interface_provider_)
yzshen1 2016/06/29 22:25:44 Why this check is needed? It seems this is never n
leonhsl(Using Gerrit) 2016/06/29 23:28:35 With the render_frame_host_impl.cc changes, Interf
yzshen1 2016/06/30 16:58:17 But the GetProxy() at line 10 guarantees that it i
leonhsl(Using Gerrit) 2016/07/01 13:04:59 Yeah you are right.. As pending_request_ is used n
+ interface_provider_.set_connection_error_handler(connection_lost_closure);
}
base::WeakPtr<InterfaceProvider> InterfaceProvider::GetWeakPtr() {
@@ -35,7 +36,8 @@ void InterfaceProvider::GetInterface(
it->second.Run(std::move(request_handle));
return;
}
- interface_provider_->GetInterface(name, std::move(request_handle));
+ if (interface_provider_)
yzshen1 2016/06/29 22:25:44 ditto.
leonhsl(Using Gerrit) 2016/07/01 13:04:59 Done.
+ interface_provider_->GetInterface(name, std::move(request_handle));
}
void InterfaceProvider::ClearBinders() {

Powered by Google App Engine
This is Rietveld 408576698