[Autofill] Migrate ContentAutofillDriver<-->AutofillAgent IPCs to mojo.

services/shell/public/cpp/lib/interface_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/shell/public/cpp/interface_provider.h"
 
 namespace shell {
 
 InterfaceProvider::InterfaceProvider() : weak_factory_(this) {
   pending_request_ = GetProxy(&interface_provider_);
 }
 InterfaceProvider::~InterfaceProvider() {}
 
 void InterfaceProvider::Bind(mojom::InterfaceProviderPtr interface_provider) {
   DCHECK(pending_request_.is_pending());
   mojo::FuseInterface(std::move(pending_request_),
                       interface_provider.PassInterface());
 }
 
 void InterfaceProvider::SetConnectionLostClosure(
     const base::Closure& connection_lost_closure) {
-  interface_provider_.set_connection_error_handler(connection_lost_closure);
+  if (interface_provider_)

[yzshen1, 2016/06/29 22:25:44]

Why this check is needed? It seems this is never null.

[leonhsl(Using Gerrit), 2016/06/29 23:28:35]

With the render_frame_host_impl.cc changes, InterfaceProvider could be
constructed but with no binding, so added the check here. 

[yzshen1, 2016/06/30 16:58:17]

But the GetProxy() at line 10 guarantees that it is not null. (The other end is
not bound, but that is okay, method calls are cached.)

Have I missed anything?

[leonhsl(Using Gerrit), 2016/07/01 13:04:59]

Yeah you are right.. As pending_request_ is used now, this check has become
unnecessary. Thanks! Done.

+    interface_provider_.set_connection_error_handler(connection_lost_closure);
 }
 
 base::WeakPtr<InterfaceProvider> InterfaceProvider::GetWeakPtr() {
   return weak_factory_.GetWeakPtr();
 }
 
 void InterfaceProvider::GetInterface(
     const std::string& name,
     mojo::ScopedMessagePipeHandle request_handle) {
   // Local binders can be registered via TestApi.
   auto it = binders_.find(name);
   if (it != binders_.end()) {
     it->second.Run(std::move(request_handle));
     return;
   }
-  interface_provider_->GetInterface(name, std::move(request_handle));
+  if (interface_provider_)

[yzshen1, 2016/06/29 22:25:44]

ditto.

[leonhsl(Using Gerrit), 2016/07/01 13:04:59]

Done.

+    interface_provider_->GetInterface(name, std::move(request_handle));
 }
 
 void InterfaceProvider::ClearBinders() {
   binders_.clear();
 }
 
 }  // namespace shell