third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h - Issue 2007463003: binding: Reimplements V8HiddenValue as V8PrivateProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2007463003: binding: Reimplements V8HiddenValue as V8PrivateProperty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

index 181933e4ff921d2f828180a42c63ca23380e9748..cfd52efeca87f58110ecafe31763fbd8930c561a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

@@ -44,8 +44,9 @@ namespace blink {

class ActiveScriptWrappable;

class DOMDataStore;

-class ThreadDebugger;

class StringCache;

+class ThreadDebugger;

+class V8PrivateProperty;

struct WrapperTypeInfo;

typedef WTF::Vector<DOMDataStore*> DOMDataStoreList;

@@ -114,6 +115,7 @@ public:

void setReportingException(bool value) { m_isReportingException = value; }

V8HiddenValue* hiddenValue() { return m_hiddenValue.get(); }

+ V8PrivateProperty* privateProperty() { return m_privateProperty.get(); }

// Accessors to the cache of interface templates.

v8::Local<v8::FunctionTemplate> findInterfaceTemplate(const DOMWrapperWorld&, const void* key);

@@ -169,6 +171,7 @@ private:

OwnPtr<StringCache> m_stringCache;

OwnPtr<V8HiddenValue> m_hiddenValue;

+ std::unique_ptr<V8PrivateProperty> m_privateProperty;

ScopedPersistent<v8::Value> m_liveRoot;

RefPtr<ScriptState> m_scriptRegexpScriptState;