Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2007463003: binding: Reimplements V8HiddenValue as V8PrivateProperty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index 1d9d8d4cfd3cfe9b10315efc52e71f501ef32185..9240fb561e9cb3eb72192acc1185f76bde73f1fe 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -30,6 +30,7 @@
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8ScriptRunner.h"
#include "core/frame/Deprecation.h"
#include "core/inspector/MainThreadDebugger.h"
@@ -56,6 +57,7 @@ V8PerIsolateData::V8PerIsolateData()
: m_isolateHolder(adoptPtr(new gin::IsolateHolder()))
, m_stringCache(adoptPtr(new StringCache(isolate())))
, m_hiddenValue(V8HiddenValue::create())
+ , m_privateProperty(V8PrivateProperty::create())
, m_constructorMode(ConstructorMode::CreateNewObject)
, m_useCounterDisabled(false)
, m_isHandlingRecursionLevelError(false)
@@ -207,6 +209,7 @@ void V8PerIsolateData::destroy(v8::Isolate* isolate)
data->m_scriptRegexpScriptState->disposePerContextData();
data->m_liveRoot.clear();
data->m_hiddenValue.reset();
+ data->m_privateProperty.reset();
data->m_stringCache->dispose();
data->m_stringCache.reset();
data->m_interfaceTemplateMapForNonMainWorld.clear();

Powered by Google App Engine
This is Rietveld 408576698