Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(844)

Issue 2007433002: Revert of MediaCaptureFromElement: add support for audio captureStream(). (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MediaCaptureFromElement: add support for audio captureStream(). (patchset #6 id:760001 of https://codereview.chromium.org/1599533003/ ) Reason for revert: The layout tests added are flakily crashing on various bots, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19683 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/65000 Original issue's description: > MediaCaptureFromElement: add support for audio captureStream(). > > This CL extends support for capturing the audio part of > a <video> or <audio> tags ( "capture" here means creating > a MediaStream out of the HTMLElement) > > It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource > wrapped into an ExternalMediaStreamAudioSource to produce data > towards the audio track. > > HtmlAudioCapturerSource also plugs into the > WebMediaPlayer's WebAudioSourceProviderImpl to get > a copy of the audio being rendered. > > Unit tests are added, and the existing LayouTests > revamped (and split into several files for clarity). > > BUG=569976, 575492 > > TEST= run chromium with > --enable-blink-features=MediaCaptureFromVideo > against e.g. > https://rawgit.com/Miguelao/demos/master/videoelementcapture.html > > Committed: https://crrev.com/77d0d446e58afbf7fab215113fcf9fe9c97e94e3 > Cr-Commit-Position: refs/heads/master@{#395205} TBR=esprehn@chromium.org,avi@chromium.org,dalecurtis@chromium.org,haraken@chromium.org,miu@chromium.org,mcasas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=569976, 575492 NOTRY=true Committed: https://crrev.com/6a3e00fc10c59402325dc29d0eab7d5794ad5bb9 Cr-Commit-Position: refs/heads/master@{#395298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -450 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/media/html_audio_element_capturer_source.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/renderer/media/html_audio_element_capturer_source.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D content/renderer/media/html_audio_element_capturer_source_unittest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 2 chunks +9 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-EME-content.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-creation.html View 2 chunks +40 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
sof
Created Revert of MediaCaptureFromElement: add support for audio captureStream().
4 years, 1 month ago (2016-05-23 07:38:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007433002/1
4 years, 1 month ago (2016-05-23 07:38:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007433002/1
4 years, 1 month ago (2016-05-23 08:01:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007433002/1
4 years, 1 month ago (2016-05-23 08:31:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007433002/1
4 years, 1 month ago (2016-05-23 09:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007433002/1
4 years, 1 month ago (2016-05-23 09:31:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007433002/1
4 years, 1 month ago (2016-05-23 09:55:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-05-23 10:00:24 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-05-23 10:01:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a3e00fc10c59402325dc29d0eab7d5794ad5bb9
Cr-Commit-Position: refs/heads/master@{#395298}

Powered by Google App Engine
This is Rietveld 408576698