Fix test expectations to use bool checks rather than null compares

Fix pointer checks to test-as-bool rather than null compares.

Various test fixtures have acquired assertions and expectations on pointers which try to compare explicitly with NULL or nullptr, rather than testing pointers as bools. These cases will break when WeakPtr is fixed to provide explicit operator bool().

Some bool-checks of other pointer containers (e.g. foo.get() == NULL) are also cleaned up.

BUG=605794
Committed: https://crrev.com/ca1070937cf760f039eae9392280b9e7c1601174
Cr-Commit-Position: refs/heads/master@{#396270}

[Wez, 2016-05-26 19:57:19]

wez@chromium.org changed reviewers:
+ rsleevi@chromium.org, zea@chromium.org

[Wez, 2016-05-26 19:57:19]

PTAL

[Nicolas Zea, 2016-05-26 19:57:57]

sync lgtm

[Wez, 2016-05-26 20:00:18]

Description was changed from

==========
Fix test expectations to use bool checks rather than null compares

BUG=605794
==========

to

==========
Fix pointer checks to test-as-bool rather than null compares.

Various test fixtures have acquired assertions and expectations on pointers
which try to compare explicitly with NULL or nullptr, rather than testing
pointers as bools. These cases will break when WeakPtr is fixed to provide
explicit operator bool().

Some bool-checks of other pointer containers (e.g. foo.get() == NULL) are also
cleaned up.

BUG=605794
==========

[Ryan Sleevi, 2016-05-26 20:00:20]

//net LGTM

[Jamie, 2016-05-26 20:17:45]

jamiewalch@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-05-26 20:17:46]

remoting/ LGTM

[Wez, 2016-05-26 20:25:31]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2016-05-26 20:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007373004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007373004/1

[commit-bot: I haz the power, 2016-05-26 20:31:02]

Description was changed from

==========
Fix pointer checks to test-as-bool rather than null compares.

Various test fixtures have acquired assertions and expectations on pointers
which try to compare explicitly with NULL or nullptr, rather than testing
pointers as bools. These cases will break when WeakPtr is fixed to provide
explicit operator bool().

Some bool-checks of other pointer containers (e.g. foo.get() == NULL) are also
cleaned up.

BUG=605794
==========

to

==========
Fix pointer checks to test-as-bool rather than null compares.

Various test fixtures have acquired assertions and expectations on pointers
which try to compare explicitly with NULL or nullptr, rather than testing
pointers as bools. These cases will break when WeakPtr is fixed to provide
explicit operator bool().

Some bool-checks of other pointer containers (e.g. foo.get() == NULL) are also
cleaned up.

BUG=605794
==========

[commit-bot: I haz the power, 2016-05-26 20:31:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-26 20:32:11]

Description was changed from

==========
Fix pointer checks to test-as-bool rather than null compares.

Various test fixtures have acquired assertions and expectations on pointers
which try to compare explicitly with NULL or nullptr, rather than testing
pointers as bools. These cases will break when WeakPtr is fixed to provide
explicit operator bool().

Some bool-checks of other pointer containers (e.g. foo.get() == NULL) are also
cleaned up.

BUG=605794
==========

to

==========
Fix pointer checks to test-as-bool rather than null compares.

Various test fixtures have acquired assertions and expectations on pointers
which try to compare explicitly with NULL or nullptr, rather than testing
pointers as bools. These cases will break when WeakPtr is fixed to provide
explicit operator bool().

Some bool-checks of other pointer containers (e.g. foo.get() == NULL) are also
cleaned up.

BUG=605794

Committed: https://crrev.com/ca1070937cf760f039eae9392280b9e7c1601174
Cr-Commit-Position: refs/heads/master@{#396270}
==========

[commit-bot: I haz the power, 2016-05-26 20:32:13]

Patchset 1 (id:??) landed as
https://crrev.com/ca1070937cf760f039eae9392280b9e7c1601174
Cr-Commit-Position: refs/heads/master@{#396270}