Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: remoting/protocol/fake_datagram_socket.cc

Issue 2007373004: Fix test expectations to use bool checks rather than null compares (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/fake_datagram_socket.cc
diff --git a/remoting/protocol/fake_datagram_socket.cc b/remoting/protocol/fake_datagram_socket.cc
index 87713eb14fbe3448f8e0561c7515477400c06be1..91eedb6f8bebed7852593517424eca2cc3acc719 100644
--- a/remoting/protocol/fake_datagram_socket.cc
+++ b/remoting/protocol/fake_datagram_socket.cc
@@ -137,7 +137,7 @@ FakeDatagramChannelFactory::FakeDatagramChannelFactory()
FakeDatagramChannelFactory::~FakeDatagramChannelFactory() {
for (ChannelsMap::iterator it = channels_.begin(); it != channels_.end();
++it) {
- EXPECT_TRUE(it->second == nullptr);
+ EXPECT_FALSE(it->second);
}
}
@@ -155,7 +155,7 @@ FakeDatagramSocket* FakeDatagramChannelFactory::GetFakeChannel(
void FakeDatagramChannelFactory::CreateChannel(
const std::string& name,
const ChannelCreatedCallback& callback) {
- EXPECT_TRUE(channels_[name] == nullptr);
+ EXPECT_FALSE(channels_[name]);
std::unique_ptr<FakeDatagramSocket> channel(new FakeDatagramSocket());
channels_[name] = channel->GetWeakPtr();
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | sync/internal_api/attachments/attachment_downloader_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698