Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2007253002: Reland of "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Fine-grained JSArrayBuffer tracking" Track based on JSArrayBuffer addresses on pages instead of the attached backing store. Details of tracking: - Scavenge: New space pages are processes in bulk on the main thread - MC: Unswept pages are processed in bulk in parallel. All other pages are processed by the sweeper concurrently. This reverts commit 93fe04afa9428f4f68dc5dd302cda83908be84a7. R=hpayer@chromium.org BUG=chromium:611688 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Committed: https://crrev.com/863d015e573798e263b35b31d2ab979739706533 Cr-Commit-Position: refs/heads/master@{#36513}

Patch Set 1 : base #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Addressed coment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -159 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 1 chunk +86 lines, -35 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 1 2 2 chunks +132 lines, -86 lines 0 comments Download
A src/heap/array-buffer-tracker-inl.h View 1 chunk +74 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +20 lines, -18 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 1 6 chunks +32 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +206 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Michael Lippautz
https://codereview.chromium.org/2007253002/diff/60001/src/heap/array-buffer-tracker.cc File src/heap/array-buffer-tracker.cc (right): https://codereview.chromium.org/2007253002/diff/60001/src/heap/array-buffer-tracker.cc#newcode164 src/heap/array-buffer-tracker.cc:164: void ArrayBufferTracker::FreeDead(Page* page) { Called from sweeper which already ...
4 years, 7 months ago (2016-05-25 10:53:27 UTC) #5
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/2007253002/diff/60001/src/heap/array-buffer-tracker.cc File src/heap/array-buffer-tracker.cc (right): https://codereview.chromium.org/2007253002/diff/60001/src/heap/array-buffer-tracker.cc#newcode164 src/heap/array-buffer-tracker.cc:164: void ArrayBufferTracker::FreeDead(Page* page) { On 2016/05/25 10:53:26, Michael ...
4 years, 7 months ago (2016-05-25 10:55:26 UTC) #6
Michael Lippautz
https://codereview.chromium.org/2007253002/diff/60001/src/heap/array-buffer-tracker.cc File src/heap/array-buffer-tracker.cc (right): https://codereview.chromium.org/2007253002/diff/60001/src/heap/array-buffer-tracker.cc#newcode164 src/heap/array-buffer-tracker.cc:164: void ArrayBufferTracker::FreeDead(Page* page) { On 2016/05/25 10:55:26, Hannes Payer ...
4 years, 7 months ago (2016-05-25 10:56:24 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007253002/80001
4 years, 7 months ago (2016-05-25 10:56:46 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 11:41:53 UTC) #11
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 11:42:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007253002/80001
4 years, 7 months ago (2016-05-25 12:06:53 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 7 months ago (2016-05-25 12:09:02 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/863d015e573798e263b35b31d2ab979739706533 Cr-Commit-Position: refs/heads/master@{#36513}
4 years, 7 months ago (2016-05-25 12:11:22 UTC) #19
Michael Lippautz
4 years, 7 months ago (2016-05-25 16:29:24 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/2011563003/ by mlippautz@chromium.org.

The reason for reverting is: Breaks webgl2 conformance tests
  https://bugs.chromium.org/p/chromium/issues/detail?id=614730.

Powered by Google App Engine
This is Rietveld 408576698