Issue 200723010: Rename MediaHasVideo bit to MediaCanToggleControls.

Issue 200723010: Rename MediaHasVideo bit to MediaCanToggleControls. (Closed)

Created:
6 years, 9 months ago by sandersd (OOO until July 31)

Modified:
6 years, 8 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, eseidel

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Rename MediaHasVideo bit to MediaCanToggleControls. Only set this bit for non-fullscreen video, since toggling is ignored for fullscreen video. Chromium side change is https://codereview.chromium.org/201573013. BUG=179489 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170701

Patch Set 2 : Alias for MediaHasVideo. #

Patch Set 3 : Remove MediaFullscreen #

Total comments: 2

Patch Set 4 : Update comment #

Patch Set 5 : Comment MediaCanToggleControls logic. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	Source/web/ContextMenuClientImpl.cpp	View	1 2 3 4	1 chunk	+6 lines, -2 lines	0 comments	Download
	M	public/web/WebContextMenuData.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

Where is the corresponding Chromium-side changes? I'm wondering if we should be changing the semantics ...

6 years, 9 months ago (2014-03-21 19:59:48 UTC) #2

sandersd (OOO until July 31)

On 2014/03/21 19:59:48, acolwell wrote: > Where is the corresponding Chromium-side changes? I'm wondering if ...

6 years, 9 months ago (2014-03-21 20:03:51 UTC) #3

sandersd (OOO until July 31)

Here it is with an alias MediaCanToggleControls.

6 years, 9 months ago (2014-03-21 20:49:39 UTC) #4

acolwell GONE FROM CHROMIUM

lgtm. Please update subject and description via "Edit Issue" so it reflects what this change ...

6 years, 9 months ago (2014-03-21 21:06:06 UTC) #5

sandersd (OOO until July 31)

https://codereview.chromium.org/200723010/diff/40001/public/web/WebContextMenuData.h File public/web/WebContextMenuData.h (right): https://codereview.chromium.org/200723010/diff/40001/public/web/WebContextMenuData.h#newcode103 public/web/WebContextMenuData.h:103: MediaHasVideo = 0x40, // Temporary alias of MediaCanToggleControls. On ...

6 years, 9 months ago (2014-03-21 21:11:41 UTC) #6

sandersd (OOO until July 31)

eseidel: please review this small change to WebContextMenuData.

6 years, 9 months ago (2014-03-25 22:42:09 UTC) #8

sandersd (OOO until July 31)

esidel: ping for OWNERS on public/web/*, Source/web/*.

6 years, 8 months ago (2014-04-01 18:50:46 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/200723010/80001

6 years, 8 months ago (2014-04-02 18:29:02 UTC) #11

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-02 19:31:17 UTC) #12

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on win_blink_rel

6 years, 8 months ago (2014-04-02 19:31:18 UTC) #13

sandersd (OOO until July 31)

The CQ bit was checked by sandersd@chromium.org

6 years, 8 months ago (2014-04-02 20:06:25 UTC) #14

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/200723010/80001

6 years, 8 months ago (2014-04-02 20:06:35 UTC) #15

Message was sent while issue was closed.

Change committed as 170701

Expand Messages | Collapse Messages